520770 - Select-All doesn't work in 3-pane tab

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Whilst testing other bugs, I just found out that select-all doesn't work in a 3-pane tab. It aborts saying that "aTab is undefined".

Bug 472076 separated out the calls to the controller so that it could override things in the mailTab code, but it did the separation wrong:

- In supportsCommand we get DefaultController.isCommandEnabled called. Which probably doesn't change much, but we should really call the right thing (which will be quicker as well).

- The doCommand function of the default controller takes the aTab as the argument, this is the missing bit that is causing select all to fail.

- I've also removed the window. as it doesn't actually add anything now mailTabs.js is its own file.

Comment 1

[David :Bienvenu]

I'll try this out.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/232a359f7c84

(and I forgot the a=blocking-tb3).