Closed Bug 473001 Opened 13 years ago Closed 12 years ago
Re-add support to reorder newsgroups using drag drop
Bug 150274 added support to reorder newsgroups through drag and drop. With the js folder pane, support for this was lost. This bug is to re-add support for this.
This patch: * Adds text/x-moz-newsfolder to drag and drop types used. * Adds support re-organising newsgroups via drag and drop.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Changes since v0.1: * Unbitrotted after push of patch on bug 465015. * When dropping multiple newsgroups, selected folders stay in the same order.
Attachment #360028 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 360028 [details] [diff] [review] Add support for newsgroups to drag and drop patch v0.1a Looks good to me, works fine too:) r=mkmelin
Target Milestone: Thunderbird 3.0rc1 → Thunderbird 3.0b2
Comment on attachment 360028 [details] [diff] [review] Add support for newsgroups to drag and drop patch v0.1a >+ // Don't allow dragging newsgroup to before/after itself. >+ let row = aRow + aOrientation; This is actually checking that you're not dragging to just before the item after (or just after the item before). I take it that something else prevents you from dropping before/after itself?
Attachment #360028 - Flags: superreview?(neil) → superreview+
Changes since v0.1a: * Adds check for before/after item. * Corrects comment for before the item after and after the item before.
Attachment #360812 - Flags: superreview?(neil) → superreview+
Attachment #360812 - Attachment description: Add support for newsgroups to drag and drop patch v0.1b → Add support for newsgroups to drag and drop patch v0.1b (Push: Comment 7)
Comment on attachment 360812 [details] [diff] [review] Add support for newsgroups to drag and drop patch v0.1b (Push: Comment 7) http://hg.mozilla.org/comm-central/rev/33ebcd9e22ba
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090208 Shredder/3.0b2pre ID:20090208025606 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090208 Shredder/3.0b2pre One more bug I noticed while verifying this fix is bug 477499.
Status: RESOLVED → VERIFIED
Added https://litmus.mozilla.org/show_test.cgi?id=9510 to BFT and FFT
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.