473060 - Download error -228 if you leave the add-on's public page before download completion

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Description

[Thomas Goldstein]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090110 Shiretoko/3.1b3pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090110 Shiretoko/3.1b3pre (.NET CLR 3.5.30729)

For example, go to: https://addons.mozilla.org/en-US/firefox/addon/1865
Start the install, and then, while the download bar fills, go to another page (go back, or go to Google, whatever).
Result: the download will stop, and a "Download error" message box will pop up.

Reproducible: Always

Comment 1

[Dave Garrett]

because: Download error
-228

I can confirm this. Have to be quick on the trigger to click to another page if it you download fast, but it does error if I go to my homepage before getting to the end. (during download or "wait" period in the beginning) Tested in 3.1b3pre on Linux.

Comment 2

[Dave Garrett]

Not sure if this is on the add-ons manager end or the AMO end. Might also be a dupe, but I can't find one.

Comment 3

[Dave Garrett]

After a bit of testing in a new profile, I've been able to reproduce this in both 3.1b3pre and 3.2a1pre but not 3.0.5.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Seems to be something from last week November.

Comment 5

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> Not sure if this is on the add-ons manager end or the AMO end.

That sounds a lot like a client bug.

Comment 6

[Ria Klaassen (not reading all bugmail)]

Regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-11-28+05%3A00%3A00&enddate=2008-11-28+21%3A00%3A00
There is a Bug 462739, a Bug 454546 and a Bug 463882. 
BTW, for some reason I need to delete the profile after every test.

Comment 7

[Dave Garrett]

(In reply to comment #6)
> BTW, for some reason I need to delete the profile after every test.

Odd, I had no such problem here.

Comment 8

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #7)
> (In reply to comment #6)
> > BTW, for some reason I need to delete the profile after every test.
> 
> Odd, I had no such problem here.

Clicking Cancel on the dialog in a unaffected build gave a false negative in a affected build.

Comment 9

[Dave Townsend [:mossop]]

Will backout bug 462739 to resolve this

Comment 10

[Dave Townsend [:mossop]]

Actually have a potential fix for this, but still working on developing unit tests for it.

Comment 11

[Dave Townsend [:mossop]]

I don't think we need this for b3, but we'll probably want to relnote it if it isn't fixed by then.

Comment 12

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This patch works by removing the request from the page's load group once the request has begun. This is after any necessary cookies have been added to the headers so does not regress bug 462739, but means that when the page is navigated away from the load group will no longer cancel the xpi request.

Tests for this exist in the test suite in bug 474763

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 359502 [details] [diff] [review]
patch rev 1

r/sr=dveditz

Comment 14

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/cd824b1dd0bb

Comment 15

[Dave Townsend [:mossop]]

Landed on branch: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d1d3a589d096

Comment 16

[Dave Townsend [:mossop]]

Comment on attachment 359502 [details] [diff] [review]
patch rev 1

We need this on branch if we also want to fix bug 462739 there

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 359502 [details] [diff] [review]
patch rev 1

Approved for 1.9.0.8, a=dveditz for release-drivers

Comment 18

[Dave Townsend [:mossop]]

Landed on branch:

Checking in xpinstall/src/CertReader.cpp;
/cvsroot/mozilla/xpinstall/src/CertReader.cpp,v  <--  CertReader.cpp
new revision: 1.13; previous revision: 1.12
done
Checking in xpinstall/src/nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v  <--  nsXPInstallManager.cpp
new revision: 1.167; previous revision: 1.166
done

Comment 19

[Al Billings [:abillings - ex-MoCo]]

(In reply to comment #0)
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.9.1b3pre) Gecko/20090110 Shiretoko/3.1b3pre (.NET CLR 3.5.30729)
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
> rv:1.9.1b3pre) Gecko/20090110 Shiretoko/3.1b3pre (.NET CLR 3.5.30729)
> 
> For example, go to: https://addons.mozilla.org/en-US/firefox/addon/1865
> Start the install, and then, while the download bar fills, go to another page
> (go back, or go to Google, whatever).
> Result: the download will stop, and a "Download error" message box will pop up.
> 
> Reproducible: Always

I cannot confirm this bug with these repro steps in 1.9.0.7 on XP (which is not surprising based on comment 3).