473665 - Port |Bug 404414 - Add keyboard shortcut to open Error Console| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The Error Console is so helpful, it deserves a shortcut.

Patch coming up.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Add Ctrl+Shift+J shortcut

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Add shortcut to Help

Will request review for this if/when the shortcut itself is accepted.

Comment 3

[[e-mail]]

Comment on attachment 357046 [details] [diff] [review]
Add Ctrl+Shift+J shortcut

> <keyset id="tasksKeys">
>   <key id="key_navigator"    key="&navigatorCmd.commandkey;"   command="Tasks:Navigator" modifiers="accel"/>
>-
>+  <key id="key_errorConsole" key="&errorConsoleCmd.commandkey;" oncommand="toJavaScriptConsole();" modifiers="accel,shift"/>
> </keyset>
> <commandset id="tasksCommands">
>   <command id="Tasks:Navigator" oncommand="toNavigator();"/>
> </commandset>
I can't decide whether this is worth its own command...

>+              <menuitem label="&errorConsoleCmd.label;" accesskey="&errorConsoleCmd.accesskey;" key="key_errorConsole" oncommand="toJavaScriptConsole();"/>
It might be a good idea to wrap this ;-)

Comment 4

[[e-mail]]

(In reply to comment #3)
> I can't decide whether this is worth its own command...
jag, any preference?

Comment 5

[[e-mail]]

Comment on attachment 357048 [details] [diff] [review]
Add shortcut to Help 

Probably belongs later on in the list, not sure whether just before or after help though.

Comment 6

[jag (Peter Annema)]

Neil, I would factor out the JS code into a command and use that from both the key and the menuitem.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Shortcut v2

New patch with review comments addressed. Also added an id to the menuitem for consistency with the others.

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 357048 [details] [diff] [review]
Add shortcut to Help 

see comment 5 for Neil's take on this

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Shortcut v3 (pushed)

New patch that actually applies (meanwhile the LoginManager switch landed) with the menuitem id changed to javascriptConsole to match Firefox and Calendar (extension compatibility). Thunderbird uses javaScriptConsole, filed bug 473936 to evaluate whether they want to switch as well.

Comment 10

[Stefan [:stefanh]]

Comment on attachment 357048 [details] [diff] [review]
Add shortcut to Help 

r=me if you put it just before Open Help.

Comment 11

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Help part v2, r=stefanh (pushed)

Help shortcut moved above Open Help Window

Comment 12

[Stefan [:stefanh]]

Comment on attachment 357343 [details] [diff] [review]
Shortcut v3 (pushed)

http://hg.mozilla.org/comm-central/rev/e9abf6393746

Comment 13

[Stefan [:stefanh]]

Comment on attachment 357367 [details] [diff] [review]
Help part v2, r=stefanh (pushed)

http://hg.mozilla.org/comm-central/rev/9b2b51394a18

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

Changing back Product from Core Graveyard to SeaMonkey. timeless, if you want to revert, please tell us your reasoning (or was this some mass change?).

Comment 15

[timeless]

it was a mass change. the component retired.