Closed Bug 473936 Opened 13 years ago Closed 13 years ago

Use javascriptConsole as Error Console menuitem id for better extension compatibility

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(3 files, 2 obsolete files)

Firefox and Calendar are using javascriptConsole as menuitem id for the Error Console and I'm adding the same for SeaMonkey in bug 473665. Thunderbird is using javaScriptConsole (different case). You might want to switch as well. I'll attach a patch that includes the TB changes. MXR/comm-central says that at least Venkman and DOMI would need to be changed as well but I don't know about existing 3rd-party extensions.
Attachment #357342 - Flags: review?(bienvenu) → review+
DOM Inspector patch depending on TB patch
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #357413 - Flags: review?(sdwilsh)
Venkman patch depending on TB patch
Attachment #357418 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 357418 [details] [diff] [review]
javascriptConsole id change, Venkman part

Sorry, r-;
You'll have to come up with a way to make this work on TB2 as well. I'm not sure how that'd work, but I presume Neil would be able to help. We make XPIs from trunk as well, which need that compat, so updating trunk point-blank in this manner is not a solution.
Attachment #357418 - Flags: review?(gijskruitbosch+bugs) → review-
Comment on attachment 357413 [details] [diff] [review]
javascriptConsole id change, DOMI part

r- for the same reasons as Gijs
Attachment #357413 - Flags: review?(sdwilsh) → review-
with fall back
Attachment #357413 - Attachment is obsolete: true
Attachment #357438 - Flags: review?(sdwilsh)
with fall back
Attachment #357418 - Attachment is obsolete: true
Attachment #357439 - Flags: review?(gijskruitbosch+bugs)
Attachment #357439 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 357439 [details] [diff] [review]
[checked in] javascriptConsole id change, Venkman part v2

r=me
Attachment #357438 - Flags: superreview?(neil)
Attachment #357438 - Flags: review?(sdwilsh)
Attachment #357438 - Flags: review+
Attachment #357438 - Flags: superreview?(neil) → superreview+
Keywords: checkin-needed
Comment on attachment 357342 [details] [diff] [review]
javascriptConsole id change, TB part
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/1396cae8a39c
Attachment #357342 - Attachment description: javascriptConsole id change, TB part → javascriptConsole id change, TB part [Checkin: Comment 9]
Comment on attachment 357438 [details] [diff] [review]
javascriptConsole id change, DOMI part v2
[Checkin: Comment 10]


http://hg.mozilla.org/dom-inspector/rev/ae6c80fca3d5
Attachment #357438 - Attachment description: javascriptConsole id change, DOMI part v2 → javascriptConsole id change, DOMI part v2 [Checkin: Comment 10]
Whiteboard: [c-n: Venkman to cvs/1.9.0]
Target Milestone: --- → Thunderbird 3.0b2
Blocks: 457254
Comment on attachment 357439 [details] [diff] [review]
[checked in] javascriptConsole id change, Venkman part v2

Checking in extensions/venkman/resources/content/venkman-overlay.xul;
/cvsroot/mozilla/extensions/venkman/resources/content/venkman-overlay.xul,v  <--  venkman-overlay.xul
new revision: 1.13; previous revision: 1.12
done
Attachment #357439 - Attachment description: javascriptConsole id change, Venkman part v2 → [checked in] javascriptConsole id change, Venkman part v2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: Venkman to cvs/1.9.0]
You need to log in before you can comment on or make changes to this bug.