475126 - Archive and Junk don't advance to next message unlike Delete. Standalone message window gets closed

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Mitra Ardron]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090123 Shredder/3.0b2pre

In the standalone message pane, Delete will display the next message, Archive won't - it goes back to the index.  

Reproducible: Always

Steps to Reproduce:
1. Open a message in standalone window
2. Click Delete - see next message
3. Click ARchive (or Junk) - window closes


Expected Results:  
The behavior should be the same, I think they should all move to the next window.

Comment 1

[hansen]

Couldn't find any duplicates.

You're right. More consistency would be the right thing.

Not sure this should depend on bug 274628, but setting it to get more eyes.

Comment 2

[Michael A. Pasek]

With "Close message window on delete" enabled and "When I mark messages as 'junk':" set to "Delete them", marking a message as "Junk" closed the window (as expected), and the focus returned to the list.

With "Close message window on delete" disabled, and same "junk" settings as above, window displayed next message.

With "Close message window on delete" enabled, and "When I mark messages a 'junk':" set to "Move them to the account's 'junk' folder", the window was closed and focus returned to the list.  Does this reproduce the reporter's problem, or is this expected, given the "Close on delete" setting ?
 
With "Close message window on delete" disabled, and same "junk" settings as above, window displayed next message.

Didn't try "Archive" button, but it would appear that moving a message out of its folder (as "Junk" and "Archive" do) is considered to be a "delete" operation for the purposes of deciding what happens to the window.  With a standalone window open, using "Message->Move To" also closes the window if "close on delete" is enabled, but moves to next message if "close on delete" is disabled.  Is that a bug, or "as designed" ?

Comment 3

[Mitra Ardron]

Ok - default settings seem to be "Close Message window on delete" and "When I mark messages as junk " Send to Junk Folder"  which is your third example above. 

The behavior you describe is NOT what I expect, I would expect it to behave the same way as delete - i.e. I can move through my email hitting the Delete, Junk or Archive keys without returning to the message list. 

Strange thing is that is what happens for me, not as documented in Comment 2, I am now running.
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.9pre) Gecko/20100802 Lanikai/3.1.2pre

Comment 4

[Michael A. Pasek]

(In reply to comment #3)
> Ok - default settings seem to be "Close Message window on delete" [...]

Actually, the default is to not "Close Message window on delete".  Viewing the variable in the Config Editor, it says:
mail.close_message_window.on_delete   user_set  boolean  true

> Strange thing is that is what happens for me, not as documented in Comment 2, I
> am now running.

For the four cases I described, what happens for you ?

I guess the question to be asked of those more knowledgeable of the "Junk" and "Archive" code is:  Should the next message be displayed regardless of the "Close message window on delete" setting ?
In the interim, disabling "Close Message window on delete" should give you the results you desire.

Comment 5

[Mitra Ardron]

I think the question is: Should it behave the same when "A"rchive "J"unk or <delete> are hit  ***No matter what the settings are*** 

Apply the common sense criteria -  I can't see any time when for example you would want a different action when hitting Junk from hitting Delete, and even less a different action to the window depending on whether hitting Junk deletes the message or files it for later deletion. 

I think the setting "Close window on delete" should probably apply to any of these actions, (and maybe be renamed)

Comment 6

[Michael A. Pasek]

(In reply to comment #5)
> I think the question is: Should it behave the same when "A"rchive "J"unk or
> <delete> are hit  ***No matter what the settings are*** 

No, I don't think so.  That's what settings are for.

> Apply the common sense criteria -  I can't see any time when for example you
> would want a different action when hitting Junk from hitting Delete, and even
> less a different action to the window depending on whether hitting Junk deletes
> the message or files it for later deletion. 

And -- for the four cases I describe -- there is no difference.  If "Close window on delete" is enabled, the window closes for "Delete", "Junk", and "Archive", whether "Junk" and "Archive" are set to move or delete (delete is just a move, anyway).

> I think the setting "Close window on delete" should probably apply to any of
> these actions, (and maybe be renamed)

It does appear to apply to all of the actions (as well as "Move") -- for me. 

(In reply to comment #3)
> Strange thing is that is what happens for me, not as documented in Comment 2, I
> am now running.
> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.9pre)
> Gecko/20100802 Lanikai/3.1.2pre

What DOES happen for you, and what is the "Close window on delete" setting ?

Comment 7

[Mitra Ardron]

I'm not suggesting ignoring settings, I'm suggesting that in each of the 4 cases the (UI) behavior for Archive / Junk / Delete should be the same - I think if "Close Window on Delete" is set, then it should also close it on Archive or Junk; and if unset it should advance to the next message in each case.  

(Where Junk puts the message is irrelevant to the UI).

Comment 8

[Michael A. Pasek]

(In reply to comment #7)
> [...] I think if "Close Window on Delete" is set, then it should also close it on
> Archive or Junk; and if unset it should advance to the next message in each
> case.  
> 
> (Where Junk puts the message is irrelevant to the UI).

Yes, it does, and the "junk" setting is irrelevant.  Re-read the 4 cases in Comment #2; if "Close Window on delete" is set, the window closes; if not, it doesn't.  At least that is the result of my testing of those 4 cases.  Is your experience different for any of those cases ?  If so, which one(s) ?

Comment 9

[Mitra Ardron]

What I see now (and not what I saw when I reported it in Jan 2009) is that for all four combinations (Junk to either Delete or Folder; Close window on delete set or unset) then Archive, Junk, & Delete all advance to next message - so clearly a different result than you are seeing. 

Rereading Comment #2 - I agree that is the expected behavior (that Junk setting is irrelevant, but Close Window on Delete is significant.)

Comment 10

[Michael A. Pasek]

(In reply to comment #9)
> [...]
> all four combinations (Junk to either Delete or Folder; Close window on delete
> set or unset) then Archive, Junk, & Delete all advance to next message - so
> clearly a different result than you are seeing. 

In the description, you said "Open the message in a standalone window"; are you opening the messages in a new tab, a new window, or an existing window (Preferences/Options, Advanced, Reading & Display, "Open new messages in:") ?  I had mine set to open "in a new window" (to get the "standalone message window").  Bug 531534 describes the case of tabs not honoring the "Close window on delete" setting.



When you say "advance to next message"
> 
> Rereading Comment #2 - I agree that is the expected behavior (that Junk setting
> is irrelevant, but Close Window on Delete is significant.)

Comment 11

[Michael A. Pasek]

Ignore last part of last comment....

Comment 12

[Wayne Mery (:wsmwk)]

This is a serious workflow issue for users who use standalone message window with "reuse existing window". (as identified by person on IRC)

other standalone window issues - https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&resolution=---&type0-0-0=nowords&value0-0-0=count%20counts&product=MailNews%20Core&product=Thunderbird&short_desc=standalone%20window&list_id=1275791

Comment 13

[Wayne Mery (:wsmwk)]

Mitra does this still reproduce for you with 115?

Comment 14

[Mitra Ardron]

No - I no longer see this bug