475170 - LDAP Lookup broken in Invite Attendees dialog

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Mark Banner (:standard8)]

I've just realised that LDAP lookup is broken in the Invite Attendees dialog. This regressed at the time of the password manager switch (well just before).

I know what the fix is, will do a patch later.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

So apart from the regression that bug 419595 caused, I found that bug 398059 also caused a regression (logins requiring a password would have been broken).

Therefore this patch completely fixes ldap autocomplete in the invite attendees dialog. I believe there may be another failure in there (it doesn't go onto the next line for me) but I think that isn't part of this bug.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 359025 [details] [diff] [review]
The fix

>diff --git a/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml b/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
>--- a/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
>+++ b/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
>@@ -988,21 +988,18 @@
> 
>+                  LDAPSession.serverURL =
>+                      Components.classes["@mozilla.org/network/io-service;1"]
>+                                .getService(Components.interfaces.nsIIOService)
>+                                .newURI(url, null, null)
>+                                .QueryInterface(Components.interfaces.nsILDAPURL);
calUtils has some helpers. Make sure you import calUtils.jsm in the constructor (for lack of alternatives) and then use:
cal.makeURL(url).QueryInterface(Components.interfaces.nsILDAPURL);


>-                  // Find out if we need to authenticate, and if so, tell the LDAP
>-                  // autocomplete session how to prompt for a password.  This window
>-                  // is being used to parent the authprompter.
No need for auth stuff anymore?

r=philipp with comments considered.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Does this also fix bug 461511 ?

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Does this also fix bug 461511 ?

I doubt it, because I think that is the bug I saw.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #2)
> (From update of attachment 359025 [details] [diff] [review])
> >-                  // Find out if we need to authenticate, and if so, tell the LDAP
> >-                  // autocomplete session how to prompt for a password.  This window
> >-                  // is being used to parent the authprompter.
> No need for auth stuff anymore?

The auth code is now encapsulated in the LDAP autocomplete code. Passing the auth prompter from this location didn't actually gain us anything.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/3078b20bc7ce

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Comment 8

[thomas]

For me, LDAP lookup seems to be broken again in Lightning 1.5.1/Thunderbird 13.0.1. Lookup works in the compose message window, but in the invitation dialog of Lightning, only the collected addresses show up. Should I open a new bug report?

Comment 9

[Stefan Sitter [:ssitter]]

No, because this is a known problem. Please see Bug 765530 Comment 9 for a temporary workaround until a fixed Lightning 1.5.* release is available.

Comment 10

[thomas]

This does not seem to be the same issue. I don't have the problems described there. No errors in the error console. It is only that the LDAP address book is not considered for suggesting possible matching addresses. 

Also, I checked the file mentioned in 2. (@ https://bugzilla.mozilla.org/show_bug.cgi?id=765530#c9):

> 2. Open the following file in a text editor:
> "extensions\{e2fda1a4-762b-4020-b5ad-
> a41df1933103}\chrome\calendar\skin\calendar\calendar-event-dialog.css"

There is not even a line mentioned in 3.:

> 3. Delete the line "@import
> url(chrome://calendar-windows/skin/calendar-event-dialog.css);"

What to do?