475526 - ASSERTION: XPIManager: output stream doesn't exist: 'mItem->mOutStream', file /Users/dave/mozilla/source/trunk/mozilla/xpinstall/src/nsXPInstallManager.cpp

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Dave Townsend [:mossop]]

bug 389816 and bug 338611 introduced two cases where it is perfectly normal for the xpi request to be cancelled before the output stream for the file has been created which makes this assertion bogus.

We should either downgrade this to a warning or something or just remove it entirely.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Actually maybe moving the assertion makes most sense. It will assert if the request was successful but there isn't an output stream.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

r/sr=dveditz

Comment 3

[Dave Townsend [:mossop]]

Pushed: http://hg.mozilla.org/mozilla-central/rev/a2460d14f637

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

Would like to land this on the 1.9.1 branch. It only affects debug builds so there is basically no risk to the Firefox product.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359047 [details] [diff] [review]
patch rev 1

a191=beltzner

Comment 6

[Dave Townsend [:mossop]]

Landed on branch http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2a11f4d6330c

Comment 7

[Dave Townsend [:mossop]]

Landed on 1.9.0.x branch:

Checking in xpinstall/src/nsXPInstallManager.cpp;
/cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v  <--  nsXPInstallManager.cpp
new revision: 1.169; previous revision: 1.168
done