475914 - Marking mail as junked, mark it as read too, even if preferences set to no

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Hurrican39]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1b3pre) Gecko/20090127 Shredder/3.0b2pre

Preferences are set to not mark as "read", mails that are marked as "junk".
When receiving new mail not automatically detected as junk mail, you just mark the mail as junk manually, by clicking the desired column, and it's immediatly marked as read.

Reproducible: Always

Steps to Reproduce:
1. Wait for new mail (not marked as junk).
2. Mark the mail as junk.
3.
Actual Results:  
Mail is moved (as set in preferences) to junk folder.
Mail is marked as read.

Expected Results:  
Mail should not be marked as read, as it never has been.

Comment 1

[WADA:World Anti-bad-Duping Agency]

IMAP? POP3?

Comment 2

[Hurrican39]

Pop3

Comment 3

[WADA:World Anti-bad-Duping Agency]

UI doesn't seem to change mailnews.ui.junk.manualMarkAsJunkMarksRead setting.
Checked with Tb 2.0.0.19 and Tb trunk 2009/1/26 build on MS Win-XP. No error message was issued in Error Console when setting change via UI.

Can setting to false via Config Editor be a workaround?
> mailnews.ui.junk.manualMarkAsJunkMarksRead = true/false (default == true)

Comment 4

[Hurrican39]

When setting mailnews.ui.junk.manualMarkAsJunkMarksRead to false via the Config Editor, mails are not marked as Read. It would have been a workaround, but :
Doing this, incoming junk mails are not moved automatically to junk folder (another bug, may be I should open one for this ?). I too faced several problems like not being able to delete the junk mail by clicking on the "Delete" button.
Rolled back to mailnews.ui.junk.manualMarkAsJunkMarksRead = true ...

Comment 5

[WADA:World Anti-bad-Duping Agency]

I could reach a bug which has "junk" in summary and has MarkAsJunkMarksRead in comment. The bug was closed as DUP of Bug 352428.
> Bug 376885 Manually marking a message as junk also marks it as read
Setting dependency to Bug 352428.

Comment 6

[WADA:World Anti-bad-Duping Agency]

> but : Doing this, incoming junk mails are not moved automatically to junk folder
> I too faced several problems like not being able to delete the junk mail by clicking on the "Delete" button.

What is your following setting?
> Tools/Options/Advanced/Reading&Display
> Reading 
>   x  Automatically mark messages as read
>      - Immediately on display
>      - After displaying for N seconds

One of next be a workaround of some new problems with manualMarkAsJunkMarksRead = false?
  (a) Disable "Automatically mark messages as read".  
  (b) Enable "Automatically mark messages as read".  
      Use "Immediately on display" instead of "After displaying for N seconds".
Im' suspecting that timer-pop-task for auto-marking-as-read is not cleared when the option is set to false.

Comment 7

[WADA:World Anti-bad-Duping Agency]

Following is also seen by Config Editor.
> mail.spam.manualMarkMode = 0
> mail.spam.markAsReadOnSpam = false
According to comment in nsMsgDBView.cpp#3023, "server-specific markAsReadOnSpam" is not applicable to "manual marling as Junk". So Bug 352428 is not direct cause of this bug. Further analysis around manualMarkAsJunkMarksRead will be required.

(A) Example of mailnews.ui.junk.manualMarkAsJunkMarksRead use http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgDBView.cpp#3023
> 3023   if (markingJunkMessagesRead)
> 3024   {
> 3025     // notes on marking junk as read:
> 3026     // 1. there are 2 occasions on which junk messages are marked as
> 3027     //    read: after a manual marking (here and in the front end) and after
> 3028     //    automatic classification by the bayesian filter (see code for local
> 3029     //    mail folders and for imap mail folders). The server-specific
> 3030     //    markAsReadOnSpam pref only applies to the latter, the former is
> 3031     //    controlled by "mailnews.ui.junk.manualMarkAsJunkMarksRead".
> 3032     // 2. even though move/delete on manual mark may be
> 3033     //    turned off, we might still need to mark as read

(B) Example of mail.spam.markAsReadOnSpam use in code
> http://mxr.mozilla.org/comm-central/source/mailnews/local/src/nsLocalMailFolder.cpp#3529
> 3529       if (markAsReadOnSpam)
> 3530       {
> 3531         rv = mDatabase->MarkRead(msgKey, true, this);
> 3532           if (!NS_SUCCEEDED(rv))
> 3533             NS_WARNING("failed marking spam message as read");
> 3534       }

Comment 8

[Hurrican39]

My settings are :
Automatically mark messages as read : true (checked)
After displaying for : 5 seconds

(a) Disable "Automatically mark messages as read".  
Works... Messages are not marked as read and moved automatically to junk folder
as set in preferences.

 (b) Enable "Automatically mark messages as read".
Works... Messages are not marked as read and moved automatically to junk folder
as set in preferences.

Comment 9

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #8)
> (a) Disable ...
> Works...
>  (b) Enable ...
> Works...

Question to clarify.
Does your "Works..." mean that problems you described in your Comment #4 with mailnews.ui.junk.manualMarkAsJunkMarksRead=false didn't occur?
i.e. You don't need to change back to mailnews.ui.junk.manualMarkAsJunkMarksRead=true to avoid new problems, if "After displaying for : 5 seconds" is disabled.

Comment 10

[[:Aureliano Buendía]]

Reporter could answer to comment #9, please?

Comment 11

[Hurrican39]

I don't understand what WADA wants. In comment #8, I did explained exactly what "Works" means... 
That means that it works like set in "Preferences", after changing the settings like WADA asked me, but id does not work with my original settings (shown in comment #8).

Comment 12

[Hurrican39]

I just made a test with actual 3.0b3 version and bug seems to be solved.
I apologize, I did test it with 3.0b2, but forgot to test it again after installing the beta 3 release...

So, my settings are now the original ones :
- Automatically mark messages as read : true (checked)
  After displaying for : 5 seconds
And now, when I mark a mail as junk in Inbox, mail is move to junk folder and is correctly not marked as read.
For me, this bug is solved. :-)
Should I change the status myself ?

Comment 13

[[:Aureliano Buendía]]

WFM per comment #12 (reporter)