Activity Manager: Need theme work

RESOLVED FIXED in Thunderbird 3.0b3

Status

P1
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: davida, Assigned: andreasn)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 3.0b3
Dependency tree / graph
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b3ux][m6][no l10n impact])

Attachments

(8 attachments, 12 obsolete attachments)

24.23 KB, image/png
Details
2.52 KB, image/png
Details
33.16 KB, image/png
Details
5.13 KB, image/png
Details
22.23 KB, patch
philor
: review+
Details | Diff | Splinter Review
208.09 KB, image/png
Details
22.14 KB, patch
philor
: review+
Details | Diff | Splinter Review
24.82 KB, patch
philor
: review+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
* the pinstripe theme could use some better icons (the autosync icon in particular is inappropriate)

* we need qute and gnomestripe themes -- note that a simple copy of the pinstripe ones with inspiration from the download manager theme is probably enough.
(Reporter)

Updated

10 years ago
Blocks: 476700
(Reporter)

Updated

10 years ago
Flags: blocking-thunderbird3+
Whiteboard: [no l10n impact]
(Reporter)

Comment 1

10 years ago
The qute & gnomestripe themes have now landed (see bug 257942).  We still need better icons, though, so keeping this bug around.
(Reporter)

Updated

10 years ago
Severity: normal → minor
Priority: -- → P1
(Reporter)

Updated

10 years ago
Whiteboard: [no l10n impact] → [no l10n impact][b3ux]
Depends on: 482253

Updated

10 years ago
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED

Updated

10 years ago
Whiteboard: [no l10n impact][b3ux] → [b3ux][no l10n impact]

Updated

10 years ago
Whiteboard: [b3ux][no l10n impact] → [b3ux] [no l10n impact]
aiming this for m5.  maybe this week andreas and I can at least scope this work out
Whiteboard: [b3ux] [no l10n impact] → [b3ux][m5][no l10n impact]
(Assignee)

Comment 3

10 years ago
Created attachment 373837 [details]
icon preview

Not sure if the metaphors used for indexing and compacting (that's not a verb!) are good enough. Opinions?
IMHO, the sending icon looks a bit "static" to me, and I think it needs some sort of picture in it so it looks a bit more like a stamp rather than just a blue square.
(Assignee)

Comment 5

10 years ago
Mark: agreed. I was thinking of putting some wind power plants or something in there (other ideas for motives are welcome).
setting this for m6

For the stamp I was wondering if it would make sense to have that red circular postal ink stamp covering it.  What the post office does to a stamp to show it's being sent/used.  I'm not sure that will come through in an icon though.
Whiteboard: [b3ux][m5][no l10n impact] → [b3ux][m6][no l10n impact]
(Assignee)

Comment 7

10 years ago
Created attachment 374044 [details]
stamp with motive and postage thingy

Ending up looking a bit too cramped with too many elements on it in my opinion.
I think it would be best to keep the motive in order to not make it look empty and don't show the red thingy. Makes it looks to different from the other send icons in the interface.
(Assignee)

Comment 8

10 years ago
Created attachment 374436 [details]
first batch of gnomestripe icons
(Assignee)

Comment 9

10 years ago
Created attachment 374492 [details]
first batch of qute icons
(Assignee)

Comment 10

9 years ago
Created attachment 374768 [details]
first batch of pinstripe icons
(Assignee)

Comment 11

9 years ago
Created attachment 374773 [details]
preview of all three themes
(Assignee)

Comment 12

9 years ago
Created attachment 375013 [details]
compacting folders metaphor ideas

The trickiest icon is the compacting icon, that according to mozillazine pretty much means sending your e-mails to the land of the dead [1].
http://kb.mozillazine.org/Thunderbird_:_Tips_:_Compacting_Folders

Some very rough icon ideas, from left to right:
Black hole, dumpster truck, fire.

As compacting also means making space on the e-mail server, we could also focus on that.
(Assignee)

Comment 13

9 years ago
Created attachment 375017 [details]
added icon focusing on the name compacting

from left to right:
"compacting letters", black hole, garbage truck, burning
Attachment #375013 - Attachment is obsolete: true
(Assignee)

Comment 14

9 years ago
Created attachment 375027 [details]
pinstripe icons

Updated pinstripe package
Attachment #374768 - Attachment is obsolete: true
(Assignee)

Comment 15

9 years ago
Created attachment 375028 [details]
updated qute icons
Attachment #374492 - Attachment is obsolete: true
(Assignee)

Comment 16

9 years ago
Created attachment 375029 [details]
updated gnomestripe icons
Attachment #374436 - Attachment is obsolete: true
(Assignee)

Comment 17

9 years ago
Created attachment 375799 [details]
updated gnomestripe icons

Finally settled on using a broom for compacting as it's about "cleaning out" from the users point of view.

<andreasn> a friend suggested on the phone that it might be like cleaning out a database, so that perhaps a broom would be suitable
<clarkbw> that works
<andreasn> because it don't feel as destructive, as say, a black hole
<davida> andreasn:  yes, cleaning better than black hole
Attachment #375029 - Attachment is obsolete: true
Depends on: 492363
(Assignee)

Comment 18

9 years ago
Created attachment 377406 [details] [diff] [review]
gnomestripe icons as patch on trunk
Attachment #375799 - Attachment is obsolete: true
(Assignee)

Comment 19

9 years ago
Created attachment 377407 [details]
screenshot of gnomestripe icons in action
(Assignee)

Comment 20

9 years ago
Created attachment 377660 [details] [diff] [review]
pinstripe icons as patch on trunk

The only thing that's kind of missing from this is the defaultprocess icon. It works like it looks now, but could use some graphical love. I'm not sure what it's supposed to represent, so I've left it like this for now.
Attachment #375027 - Attachment is obsolete: true
(Assignee)

Comment 21

9 years ago
Created attachment 377666 [details] [diff] [review]
qute icons at patch on trunk

And the qute icons. Ready for review I think.
Attachment #375028 - Attachment is obsolete: true
(Assignee)

Comment 22

9 years ago
Created attachment 379558 [details] [diff] [review]
gnomestripe v2

Updated the css based on davida's feedback on IRC:
* more spacing, so it won't look as crammed as before.
* current operation won't jump in by 2em's, but will stay aligned with the other elements.
Attachment #377406 - Attachment is obsolete: true
(Assignee)

Comment 23

9 years ago
Created attachment 379559 [details]
screenshot of old patch on the left, new on the right
Attachment #377407 - Attachment is obsolete: true
(Assignee)

Comment 24

9 years ago
Created attachment 381041 [details] [diff] [review]
qute (xp) icon and css changes as patch
Attachment #377666 - Attachment is obsolete: true
(Assignee)

Comment 25

9 years ago
Created attachment 381750 [details] [diff] [review]
pinstripe patch with icons and css fixes
Attachment #377660 - Attachment is obsolete: true
Attachment #381041 - Attachment is patch: true
Attachment #381041 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

>diff --git a/mail/themes/gnomestripe/mail/activity/activity.css b/mail/themes/gnomestripe/mail/activity/activity.css
>--- a/mail/themes/gnomestripe/mail/activity/activity.css
>+++ b/mail/themes/gnomestripe/mail/activity/activity.css
>@@ -173,7 +173,7 @@
> .activitygroupbox activity-event,
> .activitygroupbox activity-warning,
> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

pre-review nit.  you should add the tab (2 spaces) back to this
(Assignee)

Updated

9 years ago
Attachment #381750 - Flags: review?(philringnalda)
(Assignee)

Updated

9 years ago
Attachment #381041 - Flags: review?(philringnalda)
(Assignee)

Updated

9 years ago
Attachment #379558 - Flags: review?(philringnalda)
Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

Lost the indent there (which I've already got fixed locally).
Attachment #379558 - Flags: review?(philringnalda) → review+
Attachment #381041 - Flags: review?(philringnalda) → review+
Attachment #381750 - Flags: review?(philringnalda) → review+
Heh, which I see clarkbw already caught a week before me :)

Pushed all three in http://hg.mozilla.org/comm-central/rev/a4bbaf919290 - are we done here?
I see you stole my glorious review for yourself... :)

I think this bug is done.  We'll take new issues and related fixes in other bugs.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 30

9 years ago
Opened a new bug for the Vista specific icons. #506660
You need to log in before you can comment on or make changes to this bug.