Closed Bug 476695 Opened 11 years ago Closed 11 years ago

Activity Manager: Need theme work

Categories

(Thunderbird :: Mail Window Front End, defect, P1, minor)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: davida, Assigned: andreasn)

References

(Blocks 1 open bug)

Details

(Whiteboard: [b3ux][m6][no l10n impact])

Attachments

(8 files, 12 obsolete files)

24.23 KB, image/png
Details
2.52 KB, image/png
Details
33.16 KB, image/png
Details
5.13 KB, image/png
Details
22.23 KB, patch
philor
: review+
Details | Diff | Splinter Review
208.09 KB, image/png
Details
22.14 KB, patch
philor
: review+
Details | Diff | Splinter Review
24.82 KB, patch
philor
: review+
Details | Diff | Splinter Review
* the pinstripe theme could use some better icons (the autosync icon in particular is inappropriate)

* we need qute and gnomestripe themes -- note that a simple copy of the pinstripe ones with inspiration from the download manager theme is probably enough.
Blocks: 476700
Flags: blocking-thunderbird3+
Whiteboard: [no l10n impact]
The qute & gnomestripe themes have now landed (see bug 257942).  We still need better icons, though, so keeping this bug around.
Severity: normal → minor
Priority: -- → P1
Whiteboard: [no l10n impact] → [no l10n impact][b3ux]
Depends on: 482253
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Whiteboard: [no l10n impact][b3ux] → [b3ux][no l10n impact]
Whiteboard: [b3ux][no l10n impact] → [b3ux] [no l10n impact]
aiming this for m5.  maybe this week andreas and I can at least scope this work out
Whiteboard: [b3ux] [no l10n impact] → [b3ux][m5][no l10n impact]
Attached image icon preview
Not sure if the metaphors used for indexing and compacting (that's not a verb!) are good enough. Opinions?
IMHO, the sending icon looks a bit "static" to me, and I think it needs some sort of picture in it so it looks a bit more like a stamp rather than just a blue square.
Mark: agreed. I was thinking of putting some wind power plants or something in there (other ideas for motives are welcome).
setting this for m6

For the stamp I was wondering if it would make sense to have that red circular postal ink stamp covering it.  What the post office does to a stamp to show it's being sent/used.  I'm not sure that will come through in an icon though.
Whiteboard: [b3ux][m5][no l10n impact] → [b3ux][m6][no l10n impact]
Ending up looking a bit too cramped with too many elements on it in my opinion.
I think it would be best to keep the motive in order to not make it look empty and don't show the red thingy. Makes it looks to different from the other send icons in the interface.
Attached file first batch of gnomestripe icons (obsolete) —
Attached file first batch of qute icons (obsolete) —
Attached file first batch of pinstripe icons (obsolete) —
Attached image compacting folders metaphor ideas (obsolete) —
The trickiest icon is the compacting icon, that according to mozillazine pretty much means sending your e-mails to the land of the dead [1].
http://kb.mozillazine.org/Thunderbird_:_Tips_:_Compacting_Folders

Some very rough icon ideas, from left to right:
Black hole, dumpster truck, fire.

As compacting also means making space on the e-mail server, we could also focus on that.
from left to right:
"compacting letters", black hole, garbage truck, burning
Attachment #375013 - Attachment is obsolete: true
Attached file pinstripe icons (obsolete) —
Updated pinstripe package
Attachment #374768 - Attachment is obsolete: true
Attached file updated qute icons (obsolete) —
Attachment #374492 - Attachment is obsolete: true
Attached file updated gnomestripe icons (obsolete) —
Attachment #374436 - Attachment is obsolete: true
Attached file updated gnomestripe icons (obsolete) —
Finally settled on using a broom for compacting as it's about "cleaning out" from the users point of view.

<andreasn> a friend suggested on the phone that it might be like cleaning out a database, so that perhaps a broom would be suitable
<clarkbw> that works
<andreasn> because it don't feel as destructive, as say, a black hole
<davida> andreasn:  yes, cleaning better than black hole
Attachment #375029 - Attachment is obsolete: true
Depends on: 492363
Attachment #375799 - Attachment is obsolete: true
The only thing that's kind of missing from this is the defaultprocess icon. It works like it looks now, but could use some graphical love. I'm not sure what it's supposed to represent, so I've left it like this for now.
Attachment #375027 - Attachment is obsolete: true
Attached patch qute icons at patch on trunk (obsolete) — Splinter Review
And the qute icons. Ready for review I think.
Attachment #375028 - Attachment is obsolete: true
Attached patch gnomestripe v2Splinter Review
Updated the css based on davida's feedback on IRC:
* more spacing, so it won't look as crammed as before.
* current operation won't jump in by 2em's, but will stay aligned with the other elements.
Attachment #377406 - Attachment is obsolete: true
Attachment #377407 - Attachment is obsolete: true
Attachment #377666 - Attachment is obsolete: true
Attachment #377660 - Attachment is obsolete: true
Attachment #381041 - Attachment is patch: true
Attachment #381041 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

>diff --git a/mail/themes/gnomestripe/mail/activity/activity.css b/mail/themes/gnomestripe/mail/activity/activity.css
>--- a/mail/themes/gnomestripe/mail/activity/activity.css
>+++ b/mail/themes/gnomestripe/mail/activity/activity.css
>@@ -173,7 +173,7 @@
> .activitygroupbox activity-event,
> .activitygroupbox activity-warning,
> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

pre-review nit.  you should add the tab (2 spaces) back to this
Attachment #381750 - Flags: review?(philringnalda)
Attachment #381041 - Flags: review?(philringnalda)
Attachment #379558 - Flags: review?(philringnalda)
Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

Lost the indent there (which I've already got fixed locally).
Attachment #379558 - Flags: review?(philringnalda) → review+
Attachment #381041 - Flags: review?(philringnalda) → review+
Attachment #381750 - Flags: review?(philringnalda) → review+
Heh, which I see clarkbw already caught a week before me :)

Pushed all three in http://hg.mozilla.org/comm-central/rev/a4bbaf919290 - are we done here?
I see you stole my glorious review for yourself... :)

I think this bug is done.  We'll take new issues and related fixes in other bugs.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Opened a new bug for the Vista specific icons. #506660
You need to log in before you can comment on or make changes to this bug.