476695 - Activity Manager: Need theme work

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P1)

Description

[David Ascher (:davida)]

* the pinstripe theme could use some better icons (the autosync icon in particular is inappropriate)

* we need qute and gnomestripe themes -- note that a simple copy of the pinstripe ones with inspiration from the download manager theme is probably enough.

Comment 1

[David Ascher (:davida)]

The qute & gnomestripe themes have now landed (see bug 257942).  We still need better icons, though, so keeping this bug around.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

aiming this for m5.  maybe this week andreas and I can at least scope this work out

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: icon preview

Not sure if the metaphors used for indexing and compacting (that's not a verb!) are good enough. Opinions?

Comment 4

[Mark Banner (:standard8)]

IMHO, the sending icon looks a bit "static" to me, and I think it needs some sort of picture in it so it looks a bit more like a stamp rather than just a blue square.

Comment 5

[Andreas Nilsson (:andreasn)]

Mark: agreed. I was thinking of putting some wind power plants or something in there (other ideas for motives are welcome).

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

setting this for m6

For the stamp I was wondering if it would make sense to have that red circular postal ink stamp covering it.  What the post office does to a stamp to show it's being sent/used.  I'm not sure that will come through in an icon though.

Comment 7

[Andreas Nilsson (:andreasn)]

Attachment: stamp with motive and postage thingy

Ending up looking a bit too cramped with too many elements on it in my opinion.
I think it would be best to keep the motive in order to not make it look empty and don't show the red thingy. Makes it looks to different from the other send icons in the interface.

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: first batch of gnomestripe icons

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: first batch of qute icons

Comment 10

[Andreas Nilsson (:andreasn)]

Attachment: first batch of pinstripe icons

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: preview of all three themes

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: compacting folders metaphor ideas

The trickiest icon is the compacting icon, that according to mozillazine pretty much means sending your e-mails to the land of the dead [1].
http://kb.mozillazine.org/Thunderbird_:_Tips_:_Compacting_Folders

Some very rough icon ideas, from left to right:
Black hole, dumpster truck, fire.

As compacting also means making space on the e-mail server, we could also focus on that.

Comment 13

[Andreas Nilsson (:andreasn)]

Attachment: added icon focusing on the name compacting

from left to right:
"compacting letters", black hole, garbage truck, burning

Comment 14

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe icons

Updated pinstripe package

Comment 15

[Andreas Nilsson (:andreasn)]

Attachment: updated qute icons

Comment 16

[Andreas Nilsson (:andreasn)]

Attachment: updated gnomestripe icons

Comment 17

[Andreas Nilsson (:andreasn)]

Attachment: updated gnomestripe icons

Finally settled on using a broom for compacting as it's about "cleaning out" from the users point of view.

<andreasn> a friend suggested on the phone that it might be like cleaning out a database, so that perhaps a broom would be suitable
<clarkbw> that works
<andreasn> because it don't feel as destructive, as say, a black hole
<davida> andreasn:  yes, cleaning better than black hole

Comment 18

[Andreas Nilsson (:andreasn)]

Attachment: gnomestripe icons as patch on trunk

Comment 19

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of gnomestripe icons in action

Comment 20

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe icons as patch on trunk

The only thing that's kind of missing from this is the defaultprocess icon. It works like it looks now, but could use some graphical love. I'm not sure what it's supposed to represent, so I've left it like this for now.

Comment 21

[Andreas Nilsson (:andreasn)]

Attachment: qute icons at patch on trunk

And the qute icons. Ready for review I think.

Comment 22

[Andreas Nilsson (:andreasn)]

Attachment: gnomestripe v2

Updated the css based on davida's feedback on IRC:
* more spacing, so it won't look as crammed as before.
* current operation won't jump in by 2em's, but will stay aligned with the other elements.

Comment 23

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of old patch on the left, new on the right

Comment 24

[Andreas Nilsson (:andreasn)]

Attachment: qute (xp) icon and css changes as patch

Comment 25

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe patch with icons and css fixes

Comment 26

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

>diff --git a/mail/themes/gnomestripe/mail/activity/activity.css b/mail/themes/gnomestripe/mail/activity/activity.css
>--- a/mail/themes/gnomestripe/mail/activity/activity.css
>+++ b/mail/themes/gnomestripe/mail/activity/activity.css
>@@ -173,7 +173,7 @@
> .activitygroupbox activity-event,
> .activitygroupbox activity-warning,
> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

pre-review nit.  you should add the tab (2 spaces) back to this

Comment 27

[Phil Ringnalda (:philor)]

Comment on attachment 379558 [details] [diff] [review]
gnomestripe v2

> .activitygroupbox activity-process {
>-  -moz-padding-start: 2em;
>+-moz-padding-start: 3px;

Lost the indent there (which I've already got fixed locally).

Comment 28

[Phil Ringnalda (:philor)]

Heh, which I see clarkbw already caught a week before me :)

Pushed all three in http://hg.mozilla.org/comm-central/rev/a4bbaf919290 - are we done here?

Comment 29

[Bryan Clark (DevTools PM) [:clarkbw]]

I see you stole my glorious review for yourself... :)

I think this bug is done.  We'll take new issues and related fixes in other bugs.

Comment 30

[Andreas Nilsson (:andreasn)]

Opened a new bug for the Vista specific icons. #506660