Closed Bug 477687 Opened 15 years ago Closed 11 years ago

Creating new bookmark folder sometimes renames other existing one

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: amitch, Unassigned)

References

Details

(Keywords: dataloss, Whiteboard: [bugday0504]) 

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6

When adding a bookmark to folders in Bookmark toolbar, if I create a new bookmark folder and then add to it, sometimes another of the top bookmark folder or someother is renamed to the same name as the new one.
I thought it was one of the extensions, but I disabled it. I still had Openbook 2.0.1.1 & Go Parent Folder 1.6 enabled.

It is not reproducable, but has happened atleast 5 times since I started using FF 3 about 4-6 weeks back.

I am a heavy bookmarks user, 10 MB places.sqlite

Reproducible: Sometimes

Steps to Reproduce:
See above

Actual Results:  
See above

Expected Results:  
See above
(In reply to comment #0)
> I thought it was one of the extensions, but I disabled it. I still had Openbook
> 2.0.1.1 & Go Parent Folder 1.6 enabled.

what happens with these disabled too (or better in safe mode)?
Marco,

The bug is not reproducible, but happens often. Also I have missed it once when I did not noticed the renamed bookmark.

I will disable these extensions for a while and add a note in this bug, when I find something. They are fairly important for my firefox experience.
if you want to make a try, install sqlite manager extension and execute on places.sqlite the query "pragma CHECK_INTEGRITY;". Report results here, at least we will know if your issue is due to a db corruption (in such a case this is a dupe of bug 460651) or we can go on looking for an extension problem.
On doing that 1. download sqlite mgr extension, 2. select places.sqlite.3. running the query you mentioned. It prints
Last error: Not an error
Nothing else is displayed.
ops, sorry my fault the correct query is:
pragma INTEGRITY_CHECK;
No probs.
It now prints "integrity check: ok" for places
thanks, so most likely your issue is due to an add-on. would be cool to know which...
Btw, if you cannot find steps to reproduce this is probably going to be marked as invalid (as caused by an add-on) and you should contact add-on author.
If you can still reproduce with those disabled, than could be a valid one.
Hi Marco,

I will update the bug in a week or less, if it happens, without addons.

However, if reproducing means having steps and it happens everytime, that might be difficult for this one.

Regards
Amit
Hi Macro,

It is confirmed, it happens without the extensions.

INTEGRITY_CHECK still shows ok.

It renamed two of my folders to "New Folder". I did not think it had been created and pressed the button again.

Same set of bookmarks, about 15K, this time it was a regular bookmark, not on toolbar, two levels deep.

Amit
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
There is an older bug on this: bug 471581.
Keywords: dataloss
Whiteboard: [bugday0504]
Confirming that this happens to me too, and there are at least 2 other duplicate bug reports newer than this one (the dupes are: bug 558556 and bug 486975).  So we've got several confirmations on this one, and the bug is nearly 2 years old now (at least).

I've been using Firefox for nearly 10 years, so I have a lot of bookmarks with lots of folders and subfolders, and this bug makes it a nightmare.  I'm constantly finding bookmark subfolders that have been renamed to absurd things (because the new name doesn't match the contents of the folder), and there's no easy way to know what the correct name was.  I've resorted to taking daily exports of my Firefox bookmarks (each of which is ~50MB), so that when I discover that Firefox has corrupted yet another bookmark folder, I can export the bookmarks, then run a diff against various older bookmark versions from a month ago, and spend an hour trying to track down what the original name was.
Also, I forgot to say: everyone who's reading this, if this bug drives you crazy too, please log into Bugzilla and "vote" for it.  The more votes it gets, the more likely the bug will get fixed.
unfortunately due to the complicated process here, i think you'll have problems getting many people to "vote" (as it wasn't that clear how to do it). not to mention, there have been a bunch of bug reports under different numbers stating the same problem. i'm absolutely sure this is happening to many more people, but they're not knowing what to do about it, or even who to ask. "this is probably going to be marked as invalid" is a depressing thing to read when people know this is very valid & is a major pain!! [some people may not notice it happening to long afterward, but like was stated above - it wreaks havoc with bookmarks!]
Added my support for this bug. It's been driving me crazy for a while now.

Like others I haven't been able to reproduce it successfully, it just seems to happen randomly. Being much more aware of it now I'm keeping an eye out for a pattern but have found nothing so far.

A couple of things I've noticed (which may not be much help):

- Normally when creating a new folder, the new folder stays in view in the dialog box when you apply the name. When it bugs out the dialog tree view seems to reset as if it has lost focus on the created folder.

- When it's bugging out on creating a new folder there *seems* to be a delay in creating it of a second or so. Don't take this point too seriously as it could be pure coincidence when it has happened.

- The problem seems to have increased in frequency as the number of bookmarks I have increases. I have a lot of bookmarks, and a lot of nested folders.

I will keep looking for a pattern and update if I find anything.
be sure to backup your profile folder, then open the error console and run this code:

Components.utils.import("resource://gre/modules/PlacesDBUtils.jsm");PlacesDBUtils.checkAndFixDatabase();

Wait a minute till it will print results to the error console, then paste them here. This will check your places.sqlite file (bookmarks and history) for eventual issues or corruption
Marco,

Nice tip, Will keep it handy when it happens next.

When this happened, I used tskill firefox & copy of places.sqlite to other computer for sync.
The tskill is gone now.
(In reply to comment #19)

Here you go.

INTEGRITY
ok
- - -
CLEANUP
- - -
VACUUM
places.sqlite: 6373376 byte
- - -
STATS
places.sqlite: 3244032 byte
moz_bookmarks: 3688
moz_bookmarks_roots: 5
moz_keywords: 0
sqlite_sequence: 0
moz_favicons: 1181
moz_annos: 3264
moz_anno_attributes: 11
moz_items_annos: 2335
moz_places: 3488
moz_historyvisits: 17
moz_inputhistory: 1
- - -
I've had the same issue for years on Mac OS-X (which I keep current).

The bug is ike this: Say I have a sequence of top level bookmark folders: FolderA, FolderB, and FolderC. Then I add a new bookmark inside a folder created on the fly, FolderD, which I created inside of FolderB. When I am done, I'll have 2 folders named FolderD: the one I just intentionally created inside of FolderB and the folder that used to be named FolderC. That is, by adding the bookmark, FolderC was incorrectly renamed to be FolderD.

This happens to me all the time and it's really aggravating.
confirming per recurring reports, but we lack steps to reproduce consistently.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Creating new bookmark folder also renames other existing one → Creating new bookmark folder sometimes renames other existing one
When it happened again to me yesterday I managed to get a couple more bits of info. Not sure if they'll help you track it down but you never know.

I went to add a folder in the dropdown list in the add bookmark window and saw it create duplicates (when it happens there is a noticeable delay in adding the folder).

After seeing this happen, I hit cancel instead of done and it rolled back the changes. Tried the same process again a couple of times to create the folder and it appeared to make exactly the same mistake again both times consistently.

So my question is, if I notice it happening again and want to try to cancel/reproduce, is there some kind of trace/debug thing I can use to record what's happening and maybe it will be of use?
As of FF 3.6.11 (Had to revert from .13 due to proxy config issues), this still happens.

Creating a new bookmark folder renamed an earlier one in other. using "Bookmarks->Bookmark this page"

SQLite Manager extension shows places.sqlite integrity passes as Ok. I will run mak's suggestion for places.

I do use some bookmark extensions I cannot do without: OpenBook, Go Parent folder, Show Parent folder, Old Add Bookmark Behavior & Vaccum Places improved.

It happened after 6-8 months.
Here is the output from checkAndFixDatabase() command 

INTEGRITY
ok
- - -
CLEANUP
- - -
VACUUM
places.sqlite: 11808768 byte
- - -
STATS
places.sqlite: 11141120 byte
moz_bookmarks: 21318
moz_bookmarks_roots: 5
moz_keywords: 3
sqlite_sequence: 1
moz_favicons: 1034
moz_annos: 14632
moz_anno_attributes: 9
moz_items_annos: 6033
moz_places: 18210
moz_historyvisits: 2122
moz_inputhistory: 36
- - -
Hi, I am using Fedora 16 KDE 
Firefox 12.0 from Fedora packages
and I am having this bug. Some synthoms that make it reproducible to me are:
high cpu usage due playing of this HTML 5 youtube video http://www.youtube.com/watch?v=XPn9FT4kFcY
While the video is playing, if I try to create a new subfolder, Firefox will edit the parent folder name instead of creating a new one
Unfortunately we still lack good steps to reproduce or databases to reproduce...
If anyone can reproduce on current version please file a new bug.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.