477797 - Form autocomplete stops working when dragging/tearing off a tab (and closing the parent on Win/Mac)

Status: RESOLVED INACTIVE

(Toolkit :: Autocomplete, defect)

Description

[Onno Witvliet]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre

Form autocomplete stops working when dragging (the only) tab from one window to another

Reproducible: Always

Steps to Reproduce:
1. Open testcase in window, make sure its the only tab in that window
2. Prime input field with some autocomplete data
3. Press down arrow key on empty input field to show autocomplete values (still works at this point)

4. Create new browser window (Ctrl+n)
5. Drag tab with test case from the first window to the new window
6. Press down arrow on empty input field to show autocomplete values, autocomplete does not work anymore. The error console shows:

Error: 'JavaScript component does not have a method named: "openAutocompletePopup"' when calling method: [nsIAutoCompletePopup::openAutocompletePopup] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED

on each down arrow key press

Actual Results:  
Autocomplete stops working

Expected Results:  
Autocomplete should still be working

Tested with clean profile, no extensions

Comment 1

[Onno Witvliet]

Attachment: testcase

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

i can confirm this, does not happen on 1.9.0 branch, happens on 1.9.1 beta 2 too, but without console output.

on 1.9.1 prebeta 3 i get:
Error: 'JavaScript component does not have a method named: "invalidate"' when calling method: [nsIAutoCompletePopup::invalidate] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED
 ----------
Error: 'JavaScript component does not have a method named: "openAutocompletePopup"' when calling method: [nsIAutoCompletePopup::openAutocompletePopup] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED

Comment 3

[Onno Witvliet]

Regression window:

Works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081021 Minefield/3.1b2pre ID:20081021033447

Doesn't work:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081022 Minefield/3.1b2pre ID:20081022033543

Looks like this is caused bug 456002 or bug 461013

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

CCing Dão as he maybe has an idea ...

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Regression window:
> 
> Works:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081021
> Minefield/3.1b2pre ID:20081021033447
> 
> Doesn't work:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081022
> Minefield/3.1b2pre ID:20081022033543
> 
> Looks like this is caused bug 456002 or bug 461013

I'm not sure I understand your range. Dragging the only tab from window to another didn't really work before bug 456002.

Comment 6

[Onno Witvliet]

Hm, strange,
I just rechecked the regression range. I can drag and drop the only tab from one window to another with the Minefield/3.1b2pre ID:20081021033447
build (without bug 456002).
The autocomplete works in this build.
But in the next nightly (Minefield/3.1b2pre ID:20081022033543) autocomplete stops working.
For some reason I don't see the error messages in the console window this time

Comment 8

[Sylvain Pasche]

In order to reproduce the issue on Windows/Mac, the window that contained the detached tab has to be closed.

The issue also happens on Linux, but you don't have to close the window that contained the detached tab in order to reproduce.

It looks like the detached tab keeps a reference on something in the parent window.

Comment 9

[Alice0775 White]

I confirm regression range in local build, Changeset 1e91efd774f4(Bug 456002) caused the problem.

Comment 10

[Mats Palmgren (inactive)]

Attachment: wip

Not suggesting this is a fix or anything, just an observation that when
I added this then the HAS_NO_FUNCTION_NAMED errors disappears.
The popup menu still don't show up though.

Comment 11

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.