Closed Bug 477797 Opened 11 years ago Closed 2 years ago

Form autocomplete stops working when dragging/tearing off a tab (and closing the parent on Win/Mac)

Categories

(Toolkit :: Autocomplete, defect)

1.9.1 Branch
defect
Not set

Tracking

()

RESOLVED INACTIVE

People

(Reporter: mozbugs, Unassigned)

References

()

Details

(Keywords: regression, testcase)

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090209 Shiretoko/3.1b3pre

Form autocomplete stops working when dragging (the only) tab from one window to another

Reproducible: Always

Steps to Reproduce:
1. Open testcase in window, make sure its the only tab in that window
2. Prime input field with some autocomplete data
3. Press down arrow key on empty input field to show autocomplete values (still works at this point)

4. Create new browser window (Ctrl+n)
5. Drag tab with test case from the first window to the new window
6. Press down arrow on empty input field to show autocomplete values, autocomplete does not work anymore. The error console shows:

Error: 'JavaScript component does not have a method named: "openAutocompletePopup"' when calling method: [nsIAutoCompletePopup::openAutocompletePopup] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED

on each down arrow key press

Actual Results:  
Autocomplete stops working

Expected Results:  
Autocomplete should still be working

Tested with clean profile, no extensions
Attached file testcase
Component: Location Bar and Autocomplete → Form Manager
Product: Firefox → Toolkit
QA Contact: location.bar → form.manager
i can confirm this, does not happen on 1.9.0 branch, happens on 1.9.1 beta 2 too, but without console output.

on 1.9.1 prebeta 3 i get:
Error: 'JavaScript component does not have a method named: "invalidate"' when calling method: [nsIAutoCompletePopup::invalidate] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED
 ----------
Error: 'JavaScript component does not have a method named: "openAutocompletePopup"' when calling method: [nsIAutoCompletePopup::openAutocompletePopup] = NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED
Status: UNCONFIRMED → NEW
Ever confirmed: true
Version: unspecified → 1.9.1 Branch
Regression window:

Works:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081021 Minefield/3.1b2pre ID:20081021033447

Doesn't work:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081022 Minefield/3.1b2pre ID:20081022033543

Looks like this is caused bug 456002 or bug 461013
CCing Dão as he maybe has an idea ...
(In reply to comment #3)
> Regression window:
> 
> Works:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081021
> Minefield/3.1b2pre ID:20081021033447
> 
> Doesn't work:
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081022
> Minefield/3.1b2pre ID:20081022033543
> 
> Looks like this is caused bug 456002 or bug 461013

I'm not sure I understand your range. Dragging the only tab from window to another didn't really work before bug 456002.
Component: Form Manager → Autocomplete
QA Contact: form.manager → autocomplete
Hm, strange,
I just rechecked the regression range. I can drag and drop the only tab from one window to another with the Minefield/3.1b2pre ID:20081021033447
build (without bug 456002).
The autocomplete works in this build.
But in the next nightly (Minefield/3.1b2pre ID:20081022033543) autocomplete stops working.
For some reason I don't see the error messages in the console window this time
Duplicate of this bug: 495450
In order to reproduce the issue on Windows/Mac, the window that contained the detached tab has to be closed.

The issue also happens on Linux, but you don't have to close the window that contained the detached tab in order to reproduce.

It looks like the detached tab keeps a reference on something in the parent window.
Blocks: 225680
OS: Windows XP → All
Hardware: x86 → All
Summary: Form autocomplete stops working when dragging (the only) tab from one window to another → Form autocomplete stops working when dragging/tearing off a tab (and closing the parent on Win/Mac)
Blocks: 499044
I confirm regression range in local build, Changeset 1e91efd774f4(Bug 456002) caused the problem.
Attached patch wipSplinter Review
Not suggesting this is a fix or anything, just an observation that when
I added this then the HAS_NO_FUNCTION_NAMED errors disappears.
The popup menu still don't show up though.
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.