478059 - [W-1.1] View Collection

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Justin Scott [:fligtar]]

Attachment: wireframe

For W-1.1 and its sub-items in the spec (linked above), we should get started on the wireframes so that by 3/1 we can get design/graphics work going.

Attached is a mockup Boriss did last year for the original Bandwagon idea.

Comment 1

[Neil Lee [:neilio]]

Attachment: First stab at a wireframe

Okay, here's what I'm thinking for the View Collections page. The idea here is that the focus will be on being a *list*, not a page with everything about a specific add-on.

My main concern here is confusing users as to what this page is for - I don't want it to look exactly like the regular add-on lists as the main goal here is to offer "add to favorite" and feed options. Thoughts?

Comment 2

[Justin Scott [:fligtar]]

I really like it. A couple comments:

* We don't have icons/pictures for users, but we do have an icon for the collection. Perhaps the icon in the header should be moved to the collection metadata side?
* I think there should be a prominent link back to the directory, both for users that were linked directly to a collection and may not know about the directory, and for users that came from directory to get back.
* I'm not sure if the "close" link is necessary. Perhaps expanding one row will close any already open rows, so that it's not necessary.

I realized the next couple of things weren't explicitly mentioned in this part of the spec so you probably wouldn't have known about it, but:
* When a collection creator publishes an add-on to the collection, they can add comments about the add-on, like "I really love it because...". So add-ons that have these notes should be marked so that users know the publisher has written something about it, and when expanded, the comments should be displayed with the person's name/nickname that wrote it, similar to how is done in the extension: https://bug481149.bugzilla.mozilla.org/attachment.cgi?id=365252

* A collection can have multiple "authors" with one of two roles: Owner and Publisher. For the purposes of this page, considering the collection "by" all of the authors regardless of role is probably okay. We just need to list them all in the header and who published each add-on to the collection.

Comment 3

[Justin Scott [:fligtar]]

Hi Neil - any progress here?

Comment 4

[Neil Lee [:neilio]]

Hey - I have a revised wireframe ready, with one question - how many potential authors may be attached to a collection? We're not talking about possibly listing dozens of names here, are we?

Comment 5

[Neil Lee [:neilio]]

Attachment: Amended wireframe

Here's an amended version of the wireframe with the suggested changes. I wasn't sure about the "creator" list but for now the wireframe denotes the original creator by bolding the name.

Collection and comment icons are placeholders with design TBD.

Comment 6

[Justin Scott [:fligtar]]

Thanks, I think that looks good.

Comment 7

[Justin Scott [:fligtar]]

Moving to new M6 milestone. (5/21)

Comment 8

[Wil Clouser [:clouserw]]

->natbat for designs.  ->jbalogh after delivery

Comment 9

[Justin Scott [:fligtar]]

Attachment: final mockup

This is the mockup that Clearleft is currently implementing for this page.

Comment 10

[Wil Clouser [:clouserw]]

Rough CSS is in the header/footer now with bug 490889 - just need to change the layout to amo2009.

Comment 11

[Jeff Balogh (:jbalogh)]

Attachment: view collections redesign

This is a rough first patch that I can fix up in smaller pieces tomorrow.

Comment 12

[Wil Clouser [:clouserw]]

Comment on attachment 378757 [details] [diff] [review]
view collections redesign

It's looking pretty.  Stuff to fix:

- There are non localized strings in the view (e.g. Add to Favourites)
- The orange button at the top has a - instead of a +
- The 5 TODO places.  Let me know if you have questions
- "Show More Info" should turn in to "Hide More Info" on click
- I put in more add-ons than it displayed but never saw pagination

Comment 13

[Jeff Balogh (:jbalogh)]

Attachment: collection detail with ajax, pagination, sorting, bunnies

Comment 14

[Jeff Balogh (:jbalogh)]

Attachment: fixing ajax bug in the previous patch, should be applied second

Comment 15

[Wil Clouser [:clouserw]]

- Experimental add-on buttons aren't frozen before someone checks the box.  Is this something that is missing from the new CSS?

- the "<!-- mozilla.thtml procecessed for..." is being escaped for me and shows on the page

- Line 122 of views/collections/listing.thtml has a parse error

- You're calling a bunch of methods from the view with $this->controller->...  That bypasses our publish() security.  Please change those so the controller passes the data to the view properly.  In the case of something like:

+ <input value="<?=$this->controller->Collection->getNickname($collection)?>"                                                       
+                           type="hidden" name="collection" />

It would be better to just use the UUID so you don't have weird escaping errors.

Comment 16

[Jeff Balogh (:jbalogh)]

Attachment: view collections redesign

Comment 17

[Jeff Balogh (:jbalogh)]

Oh, the install buttons are coming from amo2009/install, so any problems there would be a separate bug.

Comment 18

[Wil Clouser [:clouserw]]

Comment on attachment 379229 [details] [diff] [review]
view collections redesign

s/AJAX!*/Loading.../ plzthx

Comment 19

[Jeff Balogh (:jbalogh)]

r26135

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collection/f5f9c0cb-72bf-e797-bbed-9ea2fbd21e15; collection viewing has been implemented, and we're filing new bugs as we find them.

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"