478088 - [W-1.5.3] User Profiles

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

Per the spec, users can make a list of collections they own and their subscriptions available to the public in their user profile.

Comment 1

[Justin Scott [:fligtar]]

Attachment: mockup, v1

Mockup of the new fields. I think the user profile page is in need of a more space and information efficient layout, but for now, we can just tack these onto the bottom.

Comment 2

[Justin Scott [:fligtar]]

This is ready for implementation.

Comment 3

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 4

[Fred Wenzel [:wenzel]]

Collections by... are only the ones for which the user is the owner (not admin, not publisher), I assume.

What, however, are favorite collections? The ones they are subscribed to (again, not admin, not publisher)?

Comment 5

[Justin Scott [:fligtar]]

(In reply to comment #4)
> Collections by... are only the ones for which the user is the owner (not admin,
> not publisher), I assume.
> 
Owner and publisher. If the user has any role on that collection, it should appear.

> What, however, are favorite collections? The ones they are subscribed to
> (again, not admin, not publisher)?
>
Favorite collections are "subscriptions", yeah. We'll be calling them favorites everywhere on the site.

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This patch should do it. Note that it's based on the code from bug 478106, as the DB changes from over there are accessed here.

Comment 7

[Justin Scott [:fligtar]]

Ryan, can you review this soon?

Comment 8

[Ryan Doherty (:rdoherty)]

Comment on attachment 374479 [details] [diff] [review]
Patch, rev. 1

Looks good and works.

Comment 9

[Fred Wenzel [:wenzel]]

Checked this in to r25724.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

This requires SQL to be run on preview before it's testable, right?  Checkboxes aren't persisting their checked state for me.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I offer my own profile as proof: https://preview.addons.mozilla.org/en-US/firefox/user/235535 :-)

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"