478843 - /toolkit/xre/nsAppRunner.cpp:1424:6: error: #elif with no expression

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: patch v1

When I build mozilla-central using gcc 4.4, nsAppRunner.cpp causes the following compiler error.

/home/makoto/mozilla-central/toolkit/xre/nsAppRunner.cpp:1424:6: error: #elif with no expression
gmake[1]: *** [nsAppRunner.o] Error 1
gmake[1]: Leaving directory `/home/makoto/mozilla-central/objdir-fx32/toolkit/xre'

$ gcc --version
gcc (GCC) 4.4.0 20090213 (Red Hat 4.4.0-0.18)
Copyright (C) 2009 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Comment 1

[Makoto Kato [:m_kato]]

checked in
http://hg.mozilla.org/mozilla-central/rev/9c0be870182f

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 362687 [details] [diff] [review]
patch v1

Could we please have that in 1.9.1 as it would reduce the needed patching for upcoming Linux distributions.

Comment 4

[Jim Blandy :jimb]

Landed on 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b528a9e1a777

Comment 5

[Reed Loden [:reed]]

Comment on attachment 362687 [details] [diff] [review]
patch v1

Same for 1.9.0...

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 362687 [details] [diff] [review]
patch v1

Approved for 1.9.0.12, a=dveditz for release-drivers

Comment 7

[Makoto Kato [:m_kato]]

fixed on 1.9.0.x branch

Checking in nsAppRunner.cpp;
/cvsroot/mozilla/toolkit/xre/nsAppRunner.cpp,v  <--  nsAppRunner.cpp
new revision: 1.218; previous revision: 1.217
done

Comment 8

[Makoto Kato [:m_kato]]

mistake keyword.