Closed Bug 478876 Opened 13 years ago Closed 13 years ago

make hourly builds call "make buildsymbols"

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

In bug 478221 I made it so that "make upload" will upload the symbol zip archive alongside the build. However, we're not currently calling "make buildsymbols" for hourly builds, so this won't have any effect.
I haven't tested this, since I don't have a local buildbot setup, but it's fairly simple.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #362717 - Flags: review?(bhearsum)
Attachment #362717 - Flags: review?(bhearsum) → review-
Comment on attachment 362717 [details] [diff] [review]
call make buildsymbols if uploadSymbols or uploadPackages is set

I don't think implying uploadSymbols from uploadPackages is good.

Can you do this in buildbot-configs instead? Probably need to set uploadSymbols per-platform in config.py, and pass it on in master.cfg.
Er, I don't want to upload symbols to the symbol server from the hourlies, and that's not what this patch does. This patch simply makes us call "buildsymbols" if uploadPackages is set, which will only make us create the symbol package locally. It then gets picked up in the "make upload" step, which only gets called if you have uploadPackages set.
Attachment #362717 - Flags: review- → review+
Comment on attachment 362717 [details] [diff] [review]
call make buildsymbols if uploadSymbols or uploadPackages is set

I totally misinterpreted this patch. This is totally fine, as discussed on IRC.
Pushed:
http://hg.mozilla.org/build/buildbotcustom/rev/8f2682dbae7f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reconfig'ed for this today.
Working for mozilla-central and tracemonkey, but I guess bug 478221 will need to get pushed to mozilla-1.9.1 if we want it there too.
Not sure that we care, but if we do it should be easy enough to land that.
Blocks: 480577
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.