480577 - Make Talos dump crash stacks after crashes

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Benjamin Smedberg]

This is the talos-code part of bug 458903: specify a directory at which crash symbols can be found, and Talos will search for minidumps after execution and run minidump-stackwalk on them.

Comment 1

[Benjamin Smedberg]

Attachment: Talos infrastructure for reporting crash stacks, rev. 1

This patch includes the change from bug 480558 just because I don't have MQ and am forgetting how to use CVS.

Comment 2

[Benjamin Smedberg]

Attachment: Add options to perfconfigurator, rev. 1

Comment 3

[alice nodelman [:alice] [:anode]]

Comment on attachment 364547 [details] [diff] [review]
Talos infrastructure for reporting crash stacks, rev. 1

Could this be rolled into the checks for 'busted'?  The talos code already checks to see if the browser is alive every minute or so, and then quits if it can't find an active browser process assuming that the browser has crashed.  If we roll the checkForCrashes code into that we won't be doing the check as often.

Comment 4

[Benjamin Smedberg]

It's possible that the browser can crash on shutdown, after it has finished printing the talos results: I wanted to catch that case which I believe is not caught by the busted checks.

I don't think we're doing the crash-check code often at all: I'm pretty sure that the checkForCrashes code only happens either 1) after the browser has exited or 2) after an exception was thrown.

Comment 5

[Benjamin Smedberg]

Checking in PerfConfigurator.py;
/cvsroot/mozilla/testing/performance/talos/PerfConfigurator.py,v  <--  PerfConfigurator.py
new revision: 1.10; previous revision: 1.9
done

Comment 6

[alice nodelman [:alice] [:anode]]

Comment on attachment 364547 [details] [diff] [review]
Talos infrastructure for reporting crash stacks, rev. 1

One final nit, if it successfully finds a crash and a stack it should report that to the waterfall - you can do that by raising a TalosError with an appropriate string.

Comment 7

[Benjamin Smedberg]

Attachment: Talos infrastructure for reporting crash stacks, rev. 1.1

Comment 8

[Benjamin Smedberg]

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.40; previous revision: 1.39
done
Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.20; previous revision: 1.19
done
RCS file: /cvsroot/mozilla/testing/performance/talos/breakpad/linux/minidump_stackwalk,v
done
Checking in breakpad/linux/minidump_stackwalk;
/cvsroot/mozilla/testing/performance/talos/breakpad/linux/minidump_stackwalk,v  <--  minidump_stackwalk
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/breakpad/osx/minidump_stackwalk,v
done
Checking in breakpad/osx/minidump_stackwalk;
/cvsroot/mozilla/testing/performance/talos/breakpad/osx/minidump_stackwalk,v  <--  minidump_stackwalk
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/breakpad/win32/cygwin1.dll,v
done
Checking in breakpad/win32/cygwin1.dll;
/cvsroot/mozilla/testing/performance/talos/breakpad/win32/cygwin1.dll,v  <--  cygwin1.dll
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/testing/performance/talos/breakpad/win32/minidump_stackwalk.exe,v
done
Checking in breakpad/win32/minidump_stackwalk.exe;
/cvsroot/mozilla/testing/performance/talos/breakpad/win32/minidump_stackwalk.exe,v  <--  minidump_stackwalk.exe
initial revision: 1.1
done

woohoo!

Comment 9

[(not currently active) Ted Mielczarek]

Awesome:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1236887449.1236888958.18830.gz