Closed Bug 478933 Opened 15 years ago Closed 1 month ago

Revise Tell A Friend email content

Categories

(Websites Graveyard :: spreadfirefox.com, defect)

Product:
Websites Graveyard
Component:
spreadfirefox.com
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: abuchanan, Assigned: abuchanan)

Details

(Whiteboard: strings)

Attachments

(4 files)

Old default message & conflicting message preview
37.64 KB, image/tiff
Details
"Message to be sent" message on tell-a-friend form
17.34 KB, image/jpeg
Details
Weird "path" message on tell a friend email form
15.29 KB, image/jpeg
Details
Requested modifications to the tellafriend module
1.44 KB, patch
abuchanan
: review-
Details | Diff | Splinter Review 
Hey Mary,

While I was working on bug 478296, I noticed the email content for the Tell A Friend function is pretty weak.  I was hoping you agreed and that you could wordsmith that stuff.

Currently, it's...

Check out the Firefox Web browser from Mozilla. It's a better Web experience -- Faster, Safer, and More Secure. 

http://mozilla.com/firefox

Seems like we could do better.  Whaddyathink?
Good eye :)  Yes, sir!
Hiyas:  I am trying to edit this on stage, but can't seem to find the edit prompt...any ideas?

I want to change it to the following:

Subject: [username] wants you to enjoy a better Web with Firefox

Default personal message:

Check out Firefox -- it's the award-winning Web browser from Mozilla.  
It's made by thousands of volunteers worldwide who want to make a  
better and safer Web experience for everybody!

Here is why I recommend Firefox:

* It's easy to use and blazing fast!

* It's safer with built-in phishing and malware protection to warn you of bad sites.

* It has cool features like tabs and the "awesomebar."

* You can customize it to do all sorts of things like listen to music or keep up with Twitter or Facebook directly from your browser. You can even change its color!

And, best of all...it's free!

Switching is easy and painless -- Firefox will import your bookmarks from  
your old browser. Don't just take my word for it...try it out for  
yourself!

Download it at www.firefox.com.


Message footer: Can a browser really make the Web better? Try Mozilla  
Firefox and see for yourself. www.firefox.com

Let me know if I am overlooking something obvious :)
link sent to Mary to edit
Hi Jamey;  I updated it, but still need to update the footer.

It currently is: Check out the Firefox Web browser from Mozilla. It's a better Web experience -- Faster, Safer, and More Secure.
http://mozilla.com/firefox and I want to change it to:  Message footer: Can a browser really make the Web better? Try Mozilla  
Firefox and see for yourself. http://www.firefox.com

Thanks!
OK Mary refresh
Mary I made the changes then sent a test to you and cc to me this what I got


Personal Message: Enjoy a safer and better Web experience with the Firefox Web browser.
----------------------

Can a browser really make the Web better? Try Mozilla  Firefox and see for yourself. http://www.firefox.com
Hey Jamey:  The footer is fixed, but the personal message has reverted to the old one.  Not sure how to fix this since the message text field now contains the footer text and there doesn't appear to be a field to edit the footer.

Can you look into this?

Thanks!
Hey there:  Attaching some screen shots...hoping this clarifies the problem I am encountering.

The first attachment is the footer that goes w. every email that I am referring to & the second one is the admin form that doesn't have a field for editing this.

Thanks!
Weird!!! Now the email template fields are showing up! Ignore my message above.  However, despite updating the "top message" field or the default personal message, when you go to fill out the Tell a Friend email the old default message is there.  Then below there is a preview of the message to be sent which shows the footer message.

Not sure what is going on here!  I know this is a bit confusing...
@Alex

Can i get permission to replace the development version of tellafriend in SVN with the latest version 5.x-2.7

Thanks Paul
(In reply to comment #11)
> @Alex
> 
> Can i get permission to replace the development version of tellafriend in SVN
> with the latest version 5.x-2.7
> 
> Thanks Paul

Paul, yes, please do!  Thanks
Done.

@Mary / Jamey
Does this upgrade resolve your problems?

Thanks Paul
Let me try this.  Thanks!
Hey there:  Nope, when I go to send a message it still has the old personal default message vs. the long nice one I why I choose fx :(
Ill take a look at this in the morning Mary
Target Milestone: --- → 3.0
Assignee: mary → paul
It looks as though this problem is already reported on D.O
http://drupal.org/node/361959

Ill create a patch for this now ..
http://drupal.org/node/361959#comment-1349174

I'll track progress on D.O
Where we at here?  Thanks :)
Severity: minor → blocker
Only recently posted a patch on D.O so were waiting for the project maintainer to get back to us at the moment.
As an alternative (if needed) we can probably modify this directly in the database until a working code patch comes through
That would be great!
Nothing further to report this morning.
Hey Paul:  Checking in here...any progress?
No response from the project maintainer.
Still no response from the project maintainer.
@Alex

We will probably need your Plan B.
Alex mentioned a manual fix.  Alex - will you be able to do this or should we have Paul?
Whiteboard: strings
Sent a message directly to the project maintainer via the contact form.

Let you later today if i get any feedback.
Still no feedback.
Ok.  Alex - let's just do the manual fix and call it a day.
r23809

The only way to do this was to apply Paul's patch (thanks Paul!) from http://drupal.org/node/361959#comment-1349174

bug 485320 serves to track the differences from the official version.

you can now configure the default personal message at /admin/settings/tellafriend
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
this isn't fixed until the content has actually changed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Mary, could you change the settings at https://spreadfirefox.authstage.mozilla.com/admin/settings/tellafriend
Assignee: paul → mary
Hey there:  I updated the content on the tell-a-friend page as well as the email itself.  A couple of quirky things with the actual email that is received:

* It says "Personal message:" in the body (see below for complete email).  Is it possible to make sure this doesn't appear?
* The default message footer that ensures we get the download link comes between the message body and my closing salutation.  Can we get this to come below the closing?

----

Personal Message: Check out Firefox -- it's the award-winning Web browser from Mozilla.  It's made by thousands of volunteers worldwide who want to make a  better and safer Web experience for everybody!

Here is why I recommend Firefox:

* It's easy to use and blazing fast!

* It's safer with built-in phishing and malware protection to warn you of bad sites.

* It has cool features like tabs and the "awesomebar."

* You can customize it to do all sorts of things like listen to music or keep up with Twitter or Facebook directly from your browser. You can even change its color!

And, best of all...it's free!

Switching is easy and painless -- Firefox will import your bookmarks from your old browser. Don't just take my word for it...try it out for  yourself!

Download it at www.firefox.com.
----------------------

Can a browser really make the Web better? Try Mozilla  Firefox and see for yourself. http://www.firefox.com

Best, maryc - mary@mozilla.com
Assignee: mary → paul
Hi Mary

I can make both of these changes although i think the only change that needs to be made is that we have a line break after "Personal Message:" . If we make the these changes my opinion is they will not get committed.

Any other perspectives ?

Let me know what needs to be done.

Best, Paul
Hey there:  What do you mean by not committed?  Is this a module thing that we need to commit?
Thanks :)
Sorry Mary, i meant in my opinion the changes will not get committed to the tellafriend module on D.O

We can however commit these changes into SVN on our servers. We have already
forked this module so it does already differ slightly from what is on D.O

Paul
Ah - ok :)  Can you make these changes for us then?  Thanks!
Also, our community testers have found two more things :)

- there is an odd message above the captcha.  It says:  "Message to be sent:  
Can a browser really make the Web better? Try Mozilla
Firefox and see for yourself. http://www.firefox.com"  This makes the user think this is the preview, but it's not nor is it the message.  Can we remove that all together?

- Also, when you are logged in, you see this message below the personal message field:  The ID for excluding or including this element is: edit-tellafriend-personal - the path is: tellafriend

Can this be removed as well?

Thanks and will attach screenshots.
Paul:  Can you make these needed changes?  I want to close this out.  Thanks!
Working on this now ..
(In reply to comment #39)
> Ah - ok :)  Can you make these changes for us then?  Thanks!

* It says "Personal message:" in the body (see below for complete email).  Is
it possible to make sure this doesn't appear?
.. made this change
* The default message footer that ensures we get the download link comes
between the message body and my closing salutation.  Can we get this to come
below the closing?
.. would you clarify the order again, thanks
(In reply to comment #40)
> Also, our community testers have found two more things :)
> 
> - there is an odd message above the captcha.  It says:  "Message to be sent:  
> Can a browser really make the Web better? Try Mozilla
> Firefox and see for yourself. http://www.firefox.com"  This makes the user
> think this is the preview, but it's not nor is it the message.  Can we remove
> that all together?

..I've removed this

> 

> - Also, when you are logged in, you see this message below the personal message
> field:  The ID for excluding or including this element is:
> edit-tellafriend-personal - the path is: tellafriend
> 
> Can this be removed as well?

.. I don't think this can be done with hacking the captcha module. This message is only visible to an administrator and it looks to be potentially helpful so i would be inclined to leave it in.

> 
> Thanks and will attach screenshots.
Attachment #370598 - Attachment is patch: true
Attachment #370598 - Attachment mime type: application/octet-stream → text/plain
fixed
ignore last comment, wrong bug
Comment on attachment 370598 [details] [diff] [review]
Requested modifications to the tellafriend module

this patch didn't apply cleanly for me.  try re-rolling, but diff from the SFx version of tellafriend.
Attachment #370598 - Flags: review?(buchanae) → review-
Ok, actually ill need to test this first on my local spreadfirefox server when i have the latest copy of the database on stage.

If your in a position to take the patch and test the extra couple of lines please do.

Thanks Paul
Hi Mary

I'm reassigning this back to you so that you manage its resolution.

Best, Paul
Assignee: paul → mary
Alex:  Were you able to test this?  Thanks!
Hi Alex:  There are two lingering issues with this...can you look into it?  If you don't have time I will punt to 3.1.

Issues:
* "Message to be sent":  This implies this is a message preview 
and it's not.  Can this be removed?
* In the actual mail that is sent, the default message footer that ensures we get the download link comes between the message body and my closing salutation.  Can we get this to come below the closing?

For example, the current email closing is:

[Personal message]
----------------------

Can a browser really make the Web better? Try Mozilla  Firefox and see for yourself. http://www.firefox.com

Best, maryc - mary@mozilla.com

I would like it to be:

[Personal message]

Best, maryc - mary@mozilla.com

Can a browser really make the Web better? Try Mozilla  Firefox and see for yourself. http://www.firefox.com
Target Milestone: 3.0 → 3.1
resetting severity for 3.1 milestone
Severity: blocker → normal
Assignee: mary → buchanae
Product: Websites → Websites Graveyard
Status: REOPENED → RESOLVED
Closed: 15 years ago → 1 month ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: