480436 - Find doesn't work if an email is not selected, eg start page, thunderbrowse

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.3
Build Identifier: 

Ctrl F doesn't work as long as an email is not selected. If a user Ctrl+F's the start page, the bar doesn't show up. This used to work in TB2 and TB3.0b2pre, but doesn't work in TB3.0b2.

Also, it now uses this browserid attribute, but it doesn't work because you can only open the find bar from an email message.

This is extremely annoying because it overrides ThunderBrowse.

Reproducible: Always

Steps to Reproduce:
1. Start Thunderbird
2. Ctrl F on the start page (or with ThunderBrowse, a webpage)
3.
Actual Results:  
The bar magically doesn't open. Amazing.

Expected Results:  
The bar should have opened, regardless. The browserid is a rather pointless attribute if the bar can only open in mail messages.

Comment 1

[Tyler Downer [He/Him]]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090226 Shredder/3.0b3pre.

I will look if this is desired or not, don't think it is. and what caused it.

Comment 2

[David Ascher (:davida)]

I'm not sure what the use case is for bringing up the search bar _always_ would be. bringing up the search bar if something that's searchable in an iframe is "central" makes sense.

Comment 3

[Tyler Downer [He/Him]]

True, but being able to search the titles of e-mails is a possible use. Maybe a RFE would be cool instead of a regression, not sure.

Comment 4

[bugzilla]

To be more clear and precise, the find bar ignores the browserid attribute that is supposed to (from my knowledge) show what browser element it is to search.

Comment 5

[Mark Banner (:standard8)]

> Ctrl F doesn't work as long as an email is not selected. If a user Ctrl+F's the
> start page, the bar doesn't show up. This used to work in TB2 and TB3.0b2pre,
> but doesn't work in TB3.0b2.

I believe you are wrong here - unless there's some OS differences (which I very much doubt) - from my tests on OS X, this functionality has been the same since TB 2.

> Also, it now uses this browserid attribute, but it doesn't work because you can
> only open the find bar from an email message.

Wrong. Load the start page, ensure the start page pane has focus, type the single character '/'; the find bar will then open. It is just the menu option and ctrl-F shortcut that are disabled.

> Expected Results:  
> The bar should have opened, regardless. The browserid is a rather pointless
> attribute if the bar can only open in mail messages.

As mentioned above, browserid isn't the issue, just the menu options.

To enable them would be a matter of changing what happens on the cmd_find command:

http://mxr.mozilla.org/comm-central/source/mail/base/content/mail3PaneWindowCommands.js?rev=6786ebf24275#400
http://mxr.mozilla.org/comm-central/source/mail/base/content/mail3PaneWindowCommands.js?rev=6786ebf24275#959

The only case I can currently think of where we wouldn't want to enable find is if about:blank is actually displayed.

I think we'd also want to rename the find command from "Find in this message..." to "Find in this page..." (?) if non-message content is selected.

We do similar things like this already e.g. the delete option in the address book:

http://mxr.mozilla.org/comm-central/source/mail/components/addrbook/content/abCommon.js?rev=6786ebf24275#91

Comment 6

[Mark Banner (:standard8)]

AFAICT this is now working in RC 1:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-GB; rv:1.9.1.5) Gecko/20091121 Lightning/1.0pre Thunderbird/3.0

(for at least the generic thunderbird start page, I see no reason it wouldn't work for Thunderbrowse as well).

I think I fixed it in amongst the various menu re-factorings that we have done for enabling/disabling options in tabs.