998230 - Add a stop for composition's find bar to Ctrl+Tab / Ctrl+F6 fast-track focus ring

Status: NEW

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #530629 +++

This assumes landing of bug 530629 where we implemented find bar.

STR

1) Ctrl+F to open Find bar; keep it open
1) Continue to type stuff in message body
2) Try using focus ring methods to get into Find bar:
a) Tab
b) Ctrl+Tab or Ctrl+F6

Actual Result

2a) Tab doesn't work to move focus into find bar because it's consumed as a tab character in body (OK)
2b) Ctrl+Tab or Ctrl+F6 skip find bar and proceed into contacts side bar (if shown), otherwise message header

Expected Result

2b) "Fast-Track" focus ring (Ctrl+Tab or Ctrl+F6) should include find bar search box as a stop if find bar is shown.

Fast-track focus ring:
... -> message body -> [find bar] -> [contacts side bar] -> message header -> ...

- This stop will only apply when Find bar is actually shown, so we're offering the stop only to those users who are actually using find bar so they'll probably find this useful; for users who don't use find bar, nothing changes here
- Under normal circumstances, having find bar in the fine-grained "tab" focus ring would probably be enough; however in composition, "tab" focus ring gets stuck in message body where "tab" produces TAB character instead of moving on. So practically, Find bar would be excluded from *any* focus ring unless we include it in the "fast-track" focus ring here (to solve a problem of ux-interruption)

Comment 1

[Thomas D. (:thomas8)]

While we are here, it should be easy to fix Bug 682424 as well (add fast-track stop for Contacts Side Bar). Attachment 587780 [details] has a mockup screenshot of all current fast-track stops including the pending stop on contacts side bar. On that screenshot, Find bar will be another conditional stop between stop #5 and stop #6 (conditional because we'll only stop here for users who are actually having the find bar shown). I assume the same applies for Attachment Reminder Bar, too (although a single fast-track stop for all bars might be enough).