480972 - Copy and Paste is not working properly in contentEditable (e.g. Gmail message)

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Thomas Andersen]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.6) Gecko/2009011912 Firefox/3.0.6

Copy and Paste in contentEditable areas has unexpected results.

Reproducible: Always

Steps to Reproduce:
1. Go to: http://marijn.haverbeke.nl/codemirror/htmltest.html
2. Select all in the text/html area document (CMD+A), and copy (CMD+C)
3. Try pasting the content(CMD+P) into the document.

Actual Results:  
Only a tag (<) is pasted.

Expected Results:  
Content should be pasted into the content area.

Same behaviour has been reported when using Win32

Comment 1

[Nochum Sossonko [:Natch]]

This seems like a dupe, please reopen if you can reproduce this on the latest development build: ftp://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-1.9.1/

Comment 2

[Ria Klaassen (not reading all bugmail)]

I'll reopen it for now, for I see the described behavior on Windows XP but only on trunk and only in the last few days.
Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2009-02-26+04%3A00%3A00&enddate=2009-02-26+23%3A00%3A00

Smaug, is this also due to Bug 333198? The patch in Bug 480768 doesn't fix this.

Comment 3

[Nochum Sossonko [:Natch]]

If you can't reproduce this on 1.9.1 it probably isn't that bug...

Comment 4

[Ria Klaassen (not reading all bugmail)]

Yeah, you're probably right. I get a different result now on another computer.
Sorry for bothering Smaug :) and now cc-ing Mats.
Another range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cdfbe284c207&tochange=4bdc1778459e

Comment 5

[Ria Klaassen (not reading all bugmail)]

Sorry, pasted the wrong one: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4e454c6a79ce&tochange=20c271778810

Comment 6

[Ria Klaassen (not reading all bugmail)]

One of the two editor bugs in the range of comment 5 has a wanted1.9.1+ flag so I don't know if it could cause troubles for Firefox 3.1.

Comment 7

[Mats Palmgren (inactive)]

Confirming the regression is from bug 478725 by local backout.  Investigating...

Comment 8

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Before bug 478725 the "generic insert" block was an unconditional
'else' which I made conditional "!bDidInsert || NS_FAILED(res)".
The intention was that 'bDidInsert' should reflect whether the
current node was inserted or not, but I should have moved it
inside the loop of course...
Use 'lastInsertNode' non-nullness to test whether we inserted
any node at all.

Comment 10

[nabilalk]

I see the bug on the Linux version and propose changing the bug to OS=All

Comment 13

[Thomas Andersen]

I can not reproduce this bug in Shiretoko

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090302 Shiretoko/3.1b3pre

Comment 14

[Peter S.]

Today I tried to copy something from one tab and paste it into gmail's "Compose Message" window.

I couldn't do it.  I could, however, paste it into the "To" or "Subject" field, and then re-cut and re-paste it into the Compose Message window.

Comment 15

[Priit Uring]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090326 Minefield/3.6a1pre
For some weird reason I have copy paste problem with Windows Live , Gmail bugs and Windows Live bugs appear always at same time for Me even when I make new profile :(

Comment 16

[andy]

I am also

Comment 17

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/b0188d2686dc

-> FIXED