481090 - Session restore should not special-case closed windows on Mac

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Mike Connor [:mconnor]]

Attachment: don't try to be too clever on Mac

See bug 382006 and bug 480874 for various reasons for moving on this.  On Mac, unlike other platforms, closing windows doesn't exit the app, so it's clearly a separate action.  If windows are closed directly, rather than the user exiting the application, we should treat that like they actually closed the window on purpose.

Talked with faaborg and dietrich on this, moving forward to get this taken care of.

Comment 1

[Dietrich Ayala (:dietrich)]

dupe of bug 382006?

while this patch is effective and platform-consistent, i prefer the pref approach in bug 382006, since it allows me an out when i accidentally close my browser window. being a windows switcher, this does happen from time to time.

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 365079 [details] [diff] [review]
don't try to be too clever on Mac

r=me. talked on irc about the pref approach, and i agree that this is too narrow a case to warrant a pref.

Comment 3

[Mike Connor [:mconnor]]

http://hg.mozilla.org/mozilla-central/rev/db5fa005dc76
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ac4013dc5474

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090304 Minefield/3.2a1pre ID:20090304021932

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090304 Shiretoko/3.1b3pre ID:20090304022008

Would an automated test be feasible?

Comment 6

[u279076]

As per https://bugzilla.mozilla.org/show_bug.cgi?id=368677#c38, in-litmus+
https://litmus.mozilla.org/show_test.cgi?id=7806