481370 - Port Bug 481090 (Session restore should not special-case closed windows on Mac) to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

From comment of that bug:
See bug 382006 and bug 480874 for various reasons for moving on this.  On Mac,
unlike other platforms, closing windows doesn't exit the app, so it's clearly a
separate action.  If windows are closed directly, rather than the user exiting
the application, we should treat that like they actually closed the window on
purpose.

Comment 1

[[e-mail]]

Comment on attachment 365401 [details] [diff] [review]
patch

nsSessionStore.js isn't preprocessed (yet), and this needs Mac review, e.g. stefanh.

Comment 2

[Stefan [:stefanh]]

It makes sense to me, let me just think of the fact that we're opening a new window upon re-launch with a blank page regardless of what we have set to display when you opening a new window. I'm not sure we should honor that, it just came to my mind...

Comment 3

[Philip Chee]

I guess if we are not preprocessing this file we can do something like:

if (!/Mac/.test(navigator.platform)) {
  .....
}

Comment 4

[Stefan [:stefanh]]

Comment on attachment 365401 [details] [diff] [review]
patch

( I assume that Neil minused this because the dependent bug wasn't resolved)

I'm not really familiar with this code, but I've tested this in a couple of scenarios and it works fine. And Smokey told me that only 2 Camino users have said that they wanted their previous opened windows restored :-)

Maybe it's my mac bgr, but isn't the non-mac implementation a bit odd when it assumes that you want your last closed window(s)if you have closed all your non-popup windows and just have popup windows opened?

Comment 5

[[e-mail]]

Comment on attachment 365401 [details] [diff] [review]
patch

>+#endif
>+
Nit: extra blank line belongs before the #endif

Comment 6

[Misak Khachatryan]

Attachment: for checkin. nits fixed

Comment 7

[Misak Khachatryan]

carrying forward r+ sr+ from Neil

Comment 8

[Misak Khachatryan]

actuall r+ from Stefan, sorry.

Comment 9

[Misak Khachatryan]

Attachment: for checkin, nits fixed for sure

Sorry, previous patch was identical to first. Carrying forward r+/sr+ from Stefan/Neil

Comment 10

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/7bfd2406b167