483006 - [W-1.6.4] Extension FAQ page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

Need copy for FAQ page to send to Clearleft for designs.

Comment 1

[Justin Scott [:fligtar]]

Moving to new M6 milestone. (5/21)

Comment 2

[Justin Scott [:fligtar]]

Attachment: FAQ copy

copy for FAQ page

Comment 3

[Justin Scott [:fligtar]]

Re-assigning to nobody@ for it to get picked up this release. The page design should look similar to the features page mockup in bug 483005

Comment 4

[Wil Clouser [:clouserw]]

Attachment: create collections page

/pages/ is currently broken (see 490889) but this code works in my tests

Comment 5

[Jeff Balogh (:jbalogh)]

Comment on attachment 377181 [details] [diff] [review]
create collections page

>diff --git a/site/app/controllers/pages_controller.php b/site/app/controllers

Oh my, --git!  I thought I felt a disturbance in the force.

/pages_controller.php
>index ff1f9c5..1463888 100644
>--- a/site/app/controllers/pages_controller.php
>+++ b/site/app/controllers/pages_controller.php
>@@ -111,6 +111,8 @@ class PagesController extends AppController{
>             $title = ___('page_title_faq', 'Frequently Asked Questions'); break;
>         case 'developer_faq':
>             $title = ___('page_title_developer_faq'); break;
>+        case 'collections_faq':
>+            $title = ___('page_title_collections_faq'); break;

Did you add this to the .po?

>diff --git a/site/app/locale/en_US/pages/collections_faq.thtml b/site/app/locale/en_US/pages/collections_faq.thtml 
> [..]
>+<dd>You'll need a <a href="/users/register">Mozilla Add-ons account</a> and the latest copy of <a href="http://www.getfirefox.com">Firefox</a>.</dd>

/users/register doesn't go anywhere on my dev instance.

>+
>+<dt>How do I subscribe to a collection?</dt>
>+<dd>You can subscribe to a collection by marking it as a favorite in the <a href="/collections">Collection Directory</a>. Your favorite collections will then appear as subscriptions in the Add-ons Manager.</dd>

Same with /collections.

Comment 6

[Justin Scott [:fligtar]]

I used relative URLs in the copy thinking we'd convert them to $this->url() links -- sorry, should have pointed that out.

Comment 7

[Wil Clouser [:clouserw]]

Git decided this should be in two different revisions, so r25663, r25664.

I didn't add it to the .po yet.

Comment 8

[Jeff Balogh (:jbalogh)]

+    echo $this->renderElement('search');
+    echo $this->renderElement('sidebar', array('pitch' => true));
+    echo $this->renderElement('app_chooser');

I just realized that this part is wrong.  I disregarded it because of other errors on the page.

We should be using 'amo2009/search' and 'amo2009/categories' on the new pages.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; some notes:

1) Page doesn't validate, but that's known and OK
2) https://preview.addons.mozilla.org/amo2009/img/icons/category-dropdown-up.gif is missing
3) The footer text doesn't properly wrap in at least Safari 3.2.3 (separate bug)
4) Also in Safari 3.2.3, the "Advanced" search dropdown-tab is too close to the green ">" arrow button (also obviously a separate, template bug).
5) Wil, if you'd like to hone your yet-to-be-mad-GIT-skillz even further, "If you'd like to provide general feedback please post to our newsgroup." could use a comma after "feedback,".