[W-1.6.4] Extension FAQ page

VERIFIED FIXED in 5.0.6

Status

addons.mozilla.org Graveyard
Collector Extension
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: fligtar, Assigned: clouserw)

Tracking

unspecified
5.0.6
XScale
All

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Need copy for FAQ page to send to Clearleft for designs.
(Reporter)

Updated

9 years ago
Summary: [E-1.6.4] Extension FAQ page → [W-1.6.4] Extension FAQ page
(Reporter)

Comment 1

9 years ago
Moving to new M6 milestone. (5/21)
Hardware: All → ARM
Target Milestone: BW-M4 → BW-M6
(Reporter)

Updated

9 years ago
Target Milestone: BW-M6 → 5.0.6
(Reporter)

Comment 2

9 years ago
Created attachment 375728 [details]
FAQ copy

copy for FAQ page
(Reporter)

Comment 3

9 years ago
Re-assigning to nobody@ for it to get picked up this release. The page design should look similar to the features page mockup in bug 483005
Assignee: fligtar → nobody
(Assignee)

Updated

9 years ago
Assignee: nobody → clouserw
(Assignee)

Comment 4

9 years ago
Created attachment 377181 [details] [diff] [review]
create collections page

/pages/ is currently broken (see 490889) but this code works in my tests
Attachment #377181 - Flags: review?(jbalogh)

Updated

9 years ago
Attachment #377181 - Flags: review?(jbalogh) → review+
Comment on attachment 377181 [details] [diff] [review]
create collections page

>diff --git a/site/app/controllers/pages_controller.php b/site/app/controllers

Oh my, --git!  I thought I felt a disturbance in the force.

/pages_controller.php
>index ff1f9c5..1463888 100644
>--- a/site/app/controllers/pages_controller.php
>+++ b/site/app/controllers/pages_controller.php
>@@ -111,6 +111,8 @@ class PagesController extends AppController{
>             $title = ___('page_title_faq', 'Frequently Asked Questions'); break;
>         case 'developer_faq':
>             $title = ___('page_title_developer_faq'); break;
>+        case 'collections_faq':
>+            $title = ___('page_title_collections_faq'); break;

Did you add this to the .po?

>diff --git a/site/app/locale/en_US/pages/collections_faq.thtml b/site/app/locale/en_US/pages/collections_faq.thtml 
> [..]
>+<dd>You'll need a <a href="/users/register">Mozilla Add-ons account</a> and the latest copy of <a href="http://www.getfirefox.com">Firefox</a>.</dd>

/users/register doesn't go anywhere on my dev instance.

>+
>+<dt>How do I subscribe to a collection?</dt>
>+<dd>You can subscribe to a collection by marking it as a favorite in the <a href="/collections">Collection Directory</a>. Your favorite collections will then appear as subscriptions in the Add-ons Manager.</dd>

Same with /collections.
(Reporter)

Comment 6

9 years ago
I used relative URLs in the copy thinking we'd convert them to $this->url() links -- sorry, should have pointed that out.
(Assignee)

Comment 7

9 years ago
Git decided this should be in two different revisions, so r25663, r25664.

I didn't add it to the .po yet.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
+    echo $this->renderElement('search');
+    echo $this->renderElement('sidebar', array('pitch' => true));
+    echo $this->renderElement('app_chooser');

I just realized that this part is wrong.  I disregarded it because of other errors on the page.

We should be using 'amo2009/search' and 'amo2009/categories' on the new pages.
Verified FIXED; some notes:

1) Page doesn't validate, but that's known and OK
2) https://preview.addons.mozilla.org/amo2009/img/icons/category-dropdown-up.gif is missing
3) The footer text doesn't properly wrap in at least Safari 3.2.3 (separate bug)
4) Also in Safari 3.2.3, the "Advanced" search dropdown-tab is too close to the green ">" arrow button (also obviously a separate, template bug).
5) Wil, if you'd like to hone your yet-to-be-mad-GIT-skillz even further, "If you'd like to provide general feedback please post to our newsgroup." could use a comma after "feedback,".
Status: RESOLVED → VERIFIED
Hardware: ARM → XScale
(Reporter)

Updated

8 years ago
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.