483011 - need netError.dtd override - Thunderbird displays info with browser wording for web content problems

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: 

In latest 30x nightlies we use dom/locales/en-US/chrome/netError.dtd file to provide some info (like dnsNotFound.longDesc) about problems when web content isn't available for some reason.

We should replace all occurrences of "browser" with sth more general, like "application" in that file or override "the browser strings" in tb.

Reproducible: Always

Comment 1

[Hubert Gajewski]

Confirmed.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Oh the irony, the firefox neterror.dtd is so much more generic than the generic one... This is mostly using the firefox neterror.dtd with a few titles lower cased for consistency and using "website" consistenctly in the one file.

Will attach some more diffs for comparison.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: generic vs firefox

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: firefox vs thunderbird

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 371049 [details] [diff] [review]
proposed fix

nice

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 371049 [details] [diff] [review]
proposed fix

Sigh. netErrorApp.dtd seemed like it would be such a nice idea.

Comment 7

[Magnus Melin [:mkmelin]]

changeset:   2416:1e4907fbaed7
http://hg.mozilla.org/comm-central/rev/1e4907fbaed7

->FIXED