484166 - Make use of firefox search icon

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Andreas Nilsson (:andreasn)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.7) Gecko/2009030422 Ubuntu/8.10 (intrepid) Firefox/3.0.7 Ubiquity/0.1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4pre) Gecko/20090318 Shredder/3.0b3pre

Firefox have a much nicer search icon than Thunderbird currently.

Reproducible: Always

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: patch against nightly

As the icon is already shipped inside global, all that's needed is to change the url.

Comment 2

[Tyler Downer [He/Him]]

Comment on attachment 368230 [details] [diff] [review]
patch against nightly

Not sure who this should go to.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Cool, this looks super easy. :)  I'll make a patch out of this on Saturday.  Maybe I can bump another review over to philor

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: hg patch using ff search icon

here's the patch that changes us over to using the FF search icon.  I noticed that the drop down arrow intersects the new search icon because it is at a different angle than ours currently is.  Not sure if that's intended, will attach screenshot.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: version 2, which includes the necessary jar.nm file change

missed including the jar.nm file

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of search icons compared

here's the comparison of the search icons TB2 vs. TB3 + previous patch

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: search box w/ arrow on left side

andreas: i tried this alternate version where I took the gif, auto-cropped it, and converted it to a png.  Then changed this css in the searchBox.css

.quick-search-button-dropmarker {
  margin-top: 14px;
  list-style-image: url("chrome://messenger/skin/icons/search-arrow.png");
}

If that's something we want to do we instead, we can change the patch to that.  

Hopefully we can get philor to review it once we've got a patch that's ready.

Comment 8

[Phil Ringnalda (:philor)]

What happens if you just get rid of (or decrease, I don't know if some is required to not have it clear at the top) the margin-top on the dropmarker, which is shoving it down toward the bottom? Isn't the natural and normal spot for a dropmarker vertically centered, and it was only being pushed down because we were using a Windows-style leaning-right magnifying glass that needed the dropmarker shoved down below its glass?

Are there native apps that use the (I presume that's native direction) leaning-right magnifying glass with a dropmarker, and if so where do they put it?

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of philor's suggestion in action

(In reply to comment #8)
> What happens if you just get rid of (or decrease, I don't know if some is
> required to not have it clear at the top) the margin-top on the dropmarker,
> which is shoving it down toward the bottom? Isn't the natural and normal spot
> for a dropmarker vertically centered, and it was only being pushed down because
> we were using a Windows-style leaning-right magnifying glass that needed the
> dropmarker shoved down below its glass?

It's amazing how simple that is.  Here's the screenshot showing what that looks like.  I only bumped the margin-start up 1px so it doesn't overrun the search icon.

> Are there native apps that use the (I presume that's native direction)
> leaning-right magnifying glass with a dropmarker, and if so where do they put
> it?

I couldn't find a single other use of our next generation search icon w/ drop marker, the future must not be evenly distributed.

Comment 10

[Andreas Nilsson (:andreasn)]

Bryan: that looks great!

Couldn't find any search icons with drop downs either. Evolution, Banshee and Transmission all use search icons that pops up a menu when you click them, but none of them use any arrow.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: middle aligned new dropdown arrow against the new search

here's the patch that makes it happen.

updated jar.mn file
removed the old Search-bar icon
converted search-arrow.gif to search-arrow.png
css changes to make it all happen

Comment 12

[Phil Ringnalda (:philor)]

How close to working in RTL is Gnomestripe's searchbox? Can we drop in bug 481860's -moz-transform: scaleX(-1) to flip the image, and get everything happy?

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of the RTL quick search

(In reply to comment #12)
> How close to working in RTL is Gnomestripe's searchbox? Can we drop in bug
> 481860's -moz-transform: scaleX(-1) to flip the image, and get everything
> happy?

Got it working.  Had to figure out how to test in the RTL mode.  Ended up writing a blog entry on it. http://clarkbw.net/blog/2009/04/02/testing-rtl-in-thunderbird/

Will attach patch for review in a sec.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: updated patch w/ RTL fix

here's the updated patch for review.  Only real change is the addition of the chromedir="rtl" selector.  I could have done a more specific child selector, but it doesn't look very pretty.

#quick-search-button[chromedir="rtl"] > stack > hbox > .quick-search-button-image

Comment 15

[Phil Ringnalda (:philor)]

Comment on attachment 370743 [details] [diff] [review]
updated patch w/ RTL fix

Sorry to be so slow - you've picked up a bit of rot in the jar.mn hunk, but other than that it looks great.

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: [checked in] update w/ fuzz fixes

(In reply to comment #15)
> Sorry to be so slow - you've picked up a bit of rot in the jar.mn hunk, but
> other than that it looks great.

Thanks Phil!  Updated to fix the rot issues.  carrying forward the review+

Comment 17

[Bryan Clark (DevTools PM) [:clarkbw]]

I should probably continue in here or spin out other bugs for qute and pinstripe themes to do the same thing.

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 374134 [details] [diff] [review]
[checked in] update w/ fuzz fixes

Checked in: http://hg.mozilla.org/comm-central/rev/69b81aa3618c

I'll let Bryan decide where he wants to do pinstripe and qute.

Comment 19

[Andreas Nilsson (:andreasn)]

Filed bug and patch for Vista (and XP) icon: https://bugzilla.mozilla.org/show_bug.cgi?id=506626

Need to check the status on pinstripe.
After that I think we can close this.

Comment 20

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of the search icon in pinstripe

Here is a screenshot of Thunderbird on OS X. Firefox main window at the top, Thunderbird in the middle and Firefox bookmarks in the bottom. The icons in FX bookmarks and TB looks the same.

Comment 21

[Markus Stange [:mstange]]

I fixed Mac in bug 491360.