484409 - new concept of people starring in message header

Status: RESOLVED INVALID

(Thunderbird :: Message Reader UI, enhancement)

Description

[Andreas Nilsson (:andreasn)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.7) Gecko/2009030422 Ubuntu/8.10 (intrepid) Firefox/3.0.7 Ubiquity/0.1.5
Build Identifier: 

Bryan thought the concept of starring contacts as opposed to messages felt odd, so I've done some work for them to be little dudes instead.

Reproducible: Always

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: messageHeader changes

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: new icons

Comment 3

[cmtalbert]

(In reply to comment #1)
> Created an attachment (id=368536) [details]
> messageHeader changes

Andreas, this looks cool. You should ask Bryan for review so that this gets into the queue.  

= Instructions if you need them =
1. Go to "Details" view of patch
2. Set "review:" flag to ?
3. Add in Bryan's bugzilla email ID in the text field that appears, click submit.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #0)
> Bryan thought the concept of starring contacts as opposed to messages felt odd,
> so I've done some work for them to be little dudes instead.

The reason it was done this way is that it fitted in with the star mechanism of Firefox's bookmarks and would be familiar to users. I'm happy if we want to change that now, but IMHO we should do it across all 3 platforms to be consistent for those people who do use TB on multiple platforms.

Comment 5

[Andreas Nilsson (:andreasn)]

Yes, just doing it on Linux would be odd. Will come up with graphics for Windows and Mac as well.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

We also need a larger icon to replace the 'starred48.png' size icon.  Right now I have the patch working but on second click we still use the large star for popup window.

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: WIP : swap header dude images for stars

Here's the WIP for making this happen.  I'm undecided about moving the dude icons to the left, I'll be trying that out in a second.  First a screenshot!

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of header w/ dude images

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: extra patch of dudes before labels

here's the simple and additional patch for swapping the dudes before the labels

Comment 10

[Andreas Nilsson (:andreasn)]

Attachment: icon to replace the big star

Was looking into renaming this one, but can't locate where it's references from (and DOM inspector can't help because of focus issues). Will work regardless though.

Comment 11

[Bryan Clark (DevTools PM) [:clarkbw]]

I think this one is all mine now, not sure what to do with it...

Comment 12

[Andreas Nilsson (:andreasn)]

Ready for review?

Comment 14

[Nathan Tuggy (:tuggyne)]

Is this planned to go into 3.1, or does it not have any particular target? (Perhaps, too, since 3.0 has already been released this should be abandoned -- it might not be worthwhile to change people's accustomed icons.)

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

I shouldn't be the assignee for these bugs.  Filter against clarkbfilter to delete all these from your emails.

Comment 16

[Jim Porter (:squib)]

Do we want this? Because I do. If other people agree, I could finish this off.

Comment 17

[Bryan Clark (DevTools PM) [:clarkbw]]

I still think it's a good move.

Comment 18

[Blake Winton (:bwinton) (:☕️)]

Yeah, sure, what the hell.

Comment 19

[Jim Porter (:squib)]

Assigning this to myself because otherwise, I'll forget about it *again*.

Comment 20

[Jim Porter (:squib)]

It's clearly unlikely that I'll actually get around to finishing this. Anyone else is free to take it.

Comment 21

[Wayne Mery (:wsmwk)]

Obsolete, given recent message header changes