Closed
Bug 485237
Opened 15 years ago
Closed 12 years ago
Need to treat popups consistently
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: dao, Assigned: dao)
References
()
Details
Attachments
(1 file)
|
3.38 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
getMostRecentBrowserWindow uses win.document.documentElement.getAttribute("chromehidden"). The read-only location bar, the disabled history button and the hidden tabstrip depend on !win.toolbar.visible.
So in window with a chromehidden attribute that's non-empty and doesn't contain "toolbar", external links won't open, but the user can type new addresses, open new tabs, etc..
|
||
Comment 1•13 years ago
|
||
Dão, can you provide some STR here? I'm trying to figure out what this bug is about and whether it's still valid.
|
Assignee | |
Comment 2•13 years ago
|
||
See the URL field. You may also want to look at the getMostRecentBrowserWindow implementation and look for toolbar.visible in browser.js.
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #590170 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/c797a7c68023
Target Milestone: --- → Firefox 12
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c797a7c68023
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•