Closed Bug 485237 Opened 13 years ago Closed 10 years ago

Need to treat popups consistently

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: dao, Assigned: dao)

References

()

Details

Attachments

(1 file)

getMostRecentBrowserWindow uses win.document.documentElement.getAttribute("chromehidden"). The read-only location bar, the disabled history button and the hidden tabstrip depend on !win.toolbar.visible.

So in window with a chromehidden attribute that's non-empty and doesn't contain "toolbar", external links won't open, but the user can type new addresses, open new tabs, etc..
Dão, can you provide some STR here? I'm trying to figure out what this bug is about and whether it's still valid.
See the URL field. You may also want to look at the getMostRecentBrowserWindow implementation and look for toolbar.visible in browser.js.
Blocks: 644729
Attached patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #590170 - Flags: review?(gavin.sharp)
Attachment #590170 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/c797a7c68023
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 742262
You need to log in before you can comment on or make changes to this bug.