Last Comment Bug 485237 - Need to treat popups consistently
: Need to treat popups consistently
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Dão Gottwald [:dao]
:
Mentors:
javascript:void(window.open('http://g...
Depends on: 742262 337344 470051 484315
Blocks: 644729
  Show dependency treegraph
 
Reported: 2009-03-25 13:07 PDT by Dão Gottwald [:dao]
Modified: 2012-04-08 07:06 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (3.38 KB, patch)
2012-01-20 04:43 PST, Dão Gottwald [:dao]
gavin.sharp: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2009-03-25 13:07:01 PDT
getMostRecentBrowserWindow uses win.document.documentElement.getAttribute("chromehidden"). The read-only location bar, the disabled history button and the hidden tabstrip depend on !win.toolbar.visible.

So in window with a chromehidden attribute that's non-empty and doesn't contain "toolbar", external links won't open, but the user can type new addresses, open new tabs, etc..
Comment 1 Matthew N. [:MattN] 2011-10-25 14:19:21 PDT
Dão, can you provide some STR here? I'm trying to figure out what this bug is about and whether it's still valid.
Comment 2 Dão Gottwald [:dao] 2011-10-26 06:39:56 PDT
See the URL field. You may also want to look at the getMostRecentBrowserWindow implementation and look for toolbar.visible in browser.js.
Comment 3 Dão Gottwald [:dao] 2012-01-20 04:43:23 PST
Created attachment 590170 [details] [diff] [review]
patch
Comment 5 Marco Bonardo [::mak] 2012-01-24 05:05:58 PST
https://hg.mozilla.org/mozilla-central/rev/c797a7c68023

Note You need to log in before you can comment on or make changes to this bug.