Need to treat popups consistently

RESOLVED FIXED in Firefox 12

Status

()

defect
RESOLVED FIXED
10 years ago
7 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Depends on 1 bug)

Trunk
Firefox 12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment)

Assignee

Description

10 years ago
getMostRecentBrowserWindow uses win.document.documentElement.getAttribute("chromehidden"). The read-only location bar, the disabled history button and the hidden tabstrip depend on !win.toolbar.visible.

So in window with a chromehidden attribute that's non-empty and doesn't contain "toolbar", external links won't open, but the user can type new addresses, open new tabs, etc..
Dão, can you provide some STR here? I'm trying to figure out what this bug is about and whether it's still valid.
Assignee

Comment 2

8 years ago
See the URL field. You may also want to look at the getMostRecentBrowserWindow implementation and look for toolbar.visible in browser.js.
Assignee

Updated

8 years ago
Blocks: 644729
Assignee

Comment 3

8 years ago
Posted patch patchSplinter Review
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #590170 - Flags: review?(gavin.sharp)
Attachment #590170 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/c797a7c68023
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

Updated

7 years ago
Depends on: 742262
You need to log in before you can comment on or make changes to this bug.