485665 - Insert picture does not appear in mozad.css and mozgn.css

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Chris Ilias [:cilias]]

The new method of uploading an image for an article and inserting it into an article afterward, was done in bug 450548.

Now, if we try to insert an image while the editor is using a stylesheet other than mozkb.css, the "Insert Picture" section does not appear after the image is uploaded. 

1. Go to any article that does not use mozkb.css, and click on edit.
<https://support-stage.mozilla.org/en-US/kb/Improving+articles> or <https://support-stage.mozilla.org/en-US/kb/Introduction+to+Live+Chat>.
2. In the "Upload picture:" section, click [Browse...] and select an image to upload.
3. Click on [Preview].

Expected result:
There should be an "Insert Picture" in the editor, with a thumbnail of the uploaded image.

Actual result:
No "Insert Picture" section is added, thus image cannot be inserted into the article.

If you move the article to the Live Chat Documentation category, then try to edit it, the image you tried to upload before will appear in the editor. So the upload works; the problem is just that the "Insert Picture" section does not appear.

Comment 1

[Paul Craciunoiu [:paulc]]

I'll check it out :)

Comment 2

[Paul Craciunoiu [:paulc]]

Chris, could you cc me on bug 450548? I can't access it to see more details.

Comment 3

[[:Cww]]

I can't seem to get it to work with Live Chat Documentation category.  So I can't fix bug 487947

Comment 4

[Paul Craciunoiu [:paulc]]

It seems that mozgn is using the original tiki editpage template. Can we make it use one mozad.css? In other words, is it okay if the editpage for Introduction+to+Live+Chat will become the same as Improving+articles?

Comment 5

[Chris Ilias [:cilias]]

Ideally, they should all be using the same editor (the mozkb.css one). That's bug 494101. For the interim, yes we can make it use mozad.css.

Comment 6

[Paul Craciunoiu [:paulc]]

Great! Bug 494101 should revamp the editor to "merge" both of these. We can discuss that there.

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

Simple patch to include it for mozad and create a soft link for mozgn.

Comment 8

[Laura Thomson :laura]

Comment on attachment 387560 [details] [diff] [review]
patch, v1

Be careful patching this to prod b/c of symlink.

Comment 9

[Paul Craciunoiu [:paulc]]

r29667 / r
Yeah, I looked it over carefully. See the revision numbers above! I even did a checkout of templates/styles ;)
Thanks Laura!

Comment 10

[Paul Craciunoiu [:paulc]]

Oops, second # was r29668

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Chris, mind taking verification on this?  If not, I'll be happy to do it; thanks!

Comment 12

[Chris Ilias [:cilias]]

Verified, by adding images to https://support-stage.mozilla.org/en-US/kb/Adding+screenshots?bl=n and https://support-stage.mozilla.org/en-US/kb/Introduction+to+Live+Chat?bl=n .