485785 - TB3b2 doesn't properly remember message download size limit settings

Status: VERIFIED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Jan Lachnitt]

User-Agent:       Opera/9.64 (Windows NT 6.0; U; cs) Presto/2.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; cs; rv:1.9.1b3pre) Gecko/20090223 Thunderbird/3.0b2

We have two accounts in TB. In TB2, we set Tools -> Account settings -> Disk space -> Don't download messages larger than 2000 kB for both accounts. After installing TB3b2, the limit changed to 50 kB so I rewrote the value back to 2000 for both accounts. Despite this, TB didn't download new messages larger than 50 kB. So I checked the settings and found out there was 50 kB again for both accounts.

After a few retries, TB seems to remember the new value of 2000 kB at least for the first account but in the Account settings window, it shows 50 or 2000 kB a bit randomly for both accounts.

Reproducible: Always

Steps to Reproduce:
1. Have at least two accounts.
2. Set a message download size limit (different from 50 kB) in the account settings for some accounts and click OK.
3. Check the settings.
Actual Results:  
There is usually the value of 50 kB instead of the entered value.

Expected Results:  
The settings should be remembered properly.

Comment 1

[Joshua Cranmer [:jcranmer]]

Fun story here. Yes, the display doesn't change for me either BUT the actual value is in fact being set correctly. The DOM Inspector is informing me that the value is in fact correct as well, yet the display insists on claiming that the number is really 50. XUL bug, perhaps?

Comment 2

[rsx11m]

I came across this bug when testing bug 515842, with an interesting twist. Using one IMAP account (server2) and a POP account (server3), I've checked the download size limit for server2 and changed it from 50 to 80 kB, clicking Ok. Verifying the pref, it says 80 for server2, so far it works. I'm opening the account manager again and go to the IMAP (server2) page, now it says 50 there, thus corresponding to your observation.

Then, directly from the server2 page going to the "Disk Space" page of the POP account (server3), the checkbox is correctly unchecked, but here I suddenly see the "80" in the disabled box (without the server3 pref ever having been set). Clicking Ok here will reset the server2 download pref and assign the 80 to the server3 pref, thus mixing up this setting between servers.

Looking at initServerSettings() in am-offline.js, I don't see anything wrong. This may be a weird timing issue, or somehow related to bug 499303, showing a similar inconsistency between a pref value and the respective XUL elements.

Comment 3

[Wayne Mery (:wsmwk)]

I am pretty sure there is another bug about a preference not being retained .... iirc UI always showing same value, even if changed in about:config 

now if I can just bloody remember what it was about.

Comment 4

[rsx11m]

I was hoping that the patch in bug 515316 for the retention settings would also resolve the related ones; indeed it fixed bug 499303, but *not* the issue here.

Still seen with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5pre) Gecko/20091010 Shredder/3.0pre.

Comment 5

[Michael A. Pasek]

Still occurs with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091213 Shredder/3.1a1pre.
(Shredder has local code changes; see Bug 533083; none would affect the "Disk Space" preference setting, though)

Comment 7

[Jon Wicks]

May be of interest, but first a WARNING that I AM coming from Eudora (Bug 534499) and not directly Thunderbird:

----------------------------
First Account created AND SET AS DEFAULT seems to be locked to only handle 50kb Messages limit. Any changes ignored on OK button.

Second or subsequent accounts created CAN have THEIR Message Size limit changed and it will "take" on OK button.

Change the DEFAULT to one of the other ACCOUNTS and THAT ONE NOW has a 50kb Message Size Limit. You can also be able to change the size limit on the origonally locked Message Size of the First Account and it will "take" on OK button.

--------------------
Checked this with the DOM and about:config and saw at each stage that the changes had taken place.

Looks like it could be a "default dataset" problem, not a "create account" problem. ?Is this a Read-Only Set or something?

Hope i'm some help to the programmers.

regards
scsijon

Comment 8

[sskfreedom]

I am also facing the same problem of TB3 unable to retain Disk space settings in Account Settings. This problem was not there in Thunderbird 2.0.0.23. I wish the programmers would come to a solution early since I use this preference in month end to limit the size of email downloads due to monthly broadband limit consumption.

Comment 10

[Wayne Mery (:wsmwk)]

also just reported in hendrix

Comment 11

[Mark Banner (:standard8)]

This is broken UI so we should fix it in 3.0.x. Given the aims of 3.0.1 I'm going to say we don't necessarily need it there but probably will want it for 3.0.2 at the latest.

Comment 13

[u368965]

- The bug is reported by principle since 9 months.
- The bug is not reported completely correct.
- It is an indexing problem while opening the Account Manager.
- There is no bug in the saving procedure of the Account Manager.

- To fix the bug I used following account list:
  user_pref("mail.server.server1.max_size", 2001);
  user_pref("mail.server.server2.max_size", 2002);
  user_pref("mail.server.server3.max_size", 2003);
  user_pref("mail.server.server4.max_size", 2004);
  user_pref("mail.server.server5.max_size", 2005);

- For every (repeatedly) opening of the Account Manager the values are "rotated".
- The very first access to any "message download size limit setting" will result in 50kB for this setting.
- All following accesses in any order will get the "rotated" values.
- All accessed  settings are marked as changed.
- If you click on OK every accessed setting will be overwritten in prefs.js.
- If you click on cancel prefs.js will not be overwritten but the wrong values remain effective and will be written to prefs.js with any later OK to the Account Manager.

Work Around:
If you access to any "message download size limit setting" you always need to overwrite!
Never use it simply to view the "message download size limit setting".

I hope this will be corrected soon.

Comment 14

[[e-mail]]

Attachment: Proposed patch

Setting the value attribute doesn't work reliably for textboxes, as HTML inputs have a cunning algorithm for when to ignore the value attribute. (The onSave code reads the property so it always saves the displayed value.)

Comment 15

[renato]

Some weeks ago i updated 2.0.0.23 to TB3. All runs ok (Vista OS). EXCEPT "Messages larger than" locked in 50kb. That left me pretty confused.... Now I know that this is a bug. I hope to be repaired soon. Thanks to all.

Comment 16

[u368965]

Bug is not jet fixed in TB 3.0.1

Comment 17

[rsx11m]

...not surprisingly, given that Neil's patch posted above hasn't been reviewed and checked in yet.

Comment 18

[Phil Ringnalda (:philor)]

Comment on attachment 421514 [details] [diff] [review]
Proposed patch

"cunning algorithm" in the sense of Baldrick's cunning plans?

Comment 19

[[e-mail]]

Pushed changeset 3079b1d1a3c8 to comm-central.

Comment 20

[[e-mail]]

Comment on attachment 421514 [details] [diff] [review]
Proposed patch

Requesting approval for comm-1.9.1 for dataloss bugfix.

Comment 22

[[e-mail]]

Pushed changeset 13494ff7aba1 to releases/comm-1.9.1