487675 - support browser.download.manager.retention in suite UI

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Robert Kaiser]

test_retention_is_0_closes.xul says the following:

/**
 * This tests that the download manager UI closes upon download completion when
 * browser.download.manager.retention is set to 0.  This test was added in bug
 * 413093.
 */

We don't have this functionality implemented at all in SeaMonkey yet, we should look into that.

Comment 1

[Robert Kaiser]

Note that the test itself isn't as reliable as it can be, see bug 483200

Comment 2

[Robert Kaiser]

One more note: https://developer.mozilla.org/en/Download_Manager_preferences documents what the values mean.

Comment 3

[Benoît]

Any chance to have this UI in the SeaMonkey 2.0 release? The feature already exists, after all.

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> Any chance to have this UI in the SeaMonkey 2.0 release?

Sure, if you write up that patch. I barely have the time to do all the non-code work coming along recently, I don't expect to have time myself to tend to this soon. I'd welcome a patch, though, that's why I filed the bug after all.

Comment 5

[Benoît]

Taking this one.

Comment 6

[Benoît]

Attachment: patch that adds the pref to the UI

Comment 7

[Benoît]

Attachment: patch that adds the pref to the UI ver 1.01

Removed redundant align attribute on the groupbox thanks to a tip from Ratty.

Comment 8

[[e-mail]]

Comment on attachment 403110 [details] [diff] [review]
patch that adds the pref to the UI ver 1.01

I don't like a couple of these strings.

>+<!ENTITY removeOnCompletion.label       "On completion">
"When they have completed"

>+<!ENTITY removeOnQuit.label             "On quit">
"When quitting " + application short name entity (probably need to adjust the DOCTYPE to pull it in).

Comment 9

[Benoît]

Attachment: patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]

Strings changed to the ones suggested by Neil.

Comment 10

[Benoît]

Comment on attachment 403223 [details] [diff] [review]
patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]

Requesting approval for SeaMonkey 2.0.

Comment 11

[Ian Neal]

Could you add a spin off bug for fixing help for this new pref and make it blocking of bug 423281? Thanks.

Comment 12

[Ian Neal]

Comment on attachment 403223 [details] [diff] [review]
patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]

http://hg.mozilla.org/comm-central/rev/75ff08fc784b