Closed Bug 487675 Opened 11 years ago Closed 10 years ago

support browser.download.manager.retention in suite UI

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0

People

(Reporter: kairo, Assigned: benoit)

References

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(1 file, 2 obsolete files)

test_retention_is_0_closes.xul says the following:

/**
 * This tests that the download manager UI closes upon download completion when
 * browser.download.manager.retention is set to 0.  This test was added in bug
 * 413093.
 */

We don't have this functionality implemented at all in SeaMonkey yet, we should look into that.
Note that the test itself isn't as reliable as it can be, see bug 483200
Depends on: 483200
One more note: https://developer.mozilla.org/en/Download_Manager_preferences documents what the values mean.
Any chance to have this UI in the SeaMonkey 2.0 release? The feature already exists, after all.
(In reply to comment #3)
> Any chance to have this UI in the SeaMonkey 2.0 release?

Sure, if you write up that patch. I barely have the time to do all the non-code work coming along recently, I don't expect to have time myself to tend to this soon. I'd welcome a patch, though, that's why I filed the bug after all.
Taking this one.
Assignee: nobody → benoit
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0
Attachment #403103 - Flags: superreview?
Attachment #403103 - Flags: review?
Attachment #403103 - Flags: superreview?(neil)
Attachment #403103 - Flags: superreview?
Attachment #403103 - Flags: review?(neil)
Attachment #403103 - Flags: review?
Removed redundant align attribute on the groupbox thanks to a tip from Ratty.
Attachment #403103 - Attachment is obsolete: true
Attachment #403110 - Flags: superreview?(neil)
Attachment #403110 - Flags: review?(neil)
Attachment #403103 - Flags: superreview?(neil)
Attachment #403103 - Flags: review?(neil)
Comment on attachment 403110 [details] [diff] [review]
patch that adds the pref to the UI ver 1.01

I don't like a couple of these strings.

>+<!ENTITY removeOnCompletion.label       "On completion">
"When they have completed"

>+<!ENTITY removeOnQuit.label             "On quit">
"When quitting " + application short name entity (probably need to adjust the DOCTYPE to pull it in).
Strings changed to the ones suggested by Neil.
Attachment #403110 - Attachment is obsolete: true
Attachment #403223 - Flags: superreview?(neil)
Attachment #403223 - Flags: review?(neil)
Attachment #403110 - Flags: superreview?(neil)
Attachment #403110 - Flags: review?(neil)
Attachment #403223 - Flags: superreview?(neil)
Attachment #403223 - Flags: superreview+
Attachment #403223 - Flags: review?(neil)
Attachment #403223 - Flags: review+
Comment on attachment 403223 [details] [diff] [review]
patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]

Requesting approval for SeaMonkey 2.0.
Attachment #403223 - Flags: approval-seamonkey2.0?
Attachment #403223 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Could you add a spin off bug for fixing help for this new pref and make it blocking of bug 423281? Thanks.
Comment on attachment 403223 [details] [diff] [review]
patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]

http://hg.mozilla.org/comm-central/rev/75ff08fc784b
Attachment #403223 - Attachment description: patch that adds the pref to the UI ver 1.02 → patch that adds the pref to the UI ver 1.02 [Checkin: Comment 12]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 519332
Blocks: 566484
You need to log in before you can comment on or make changes to this bug.