Closed
Bug 487694
Opened 15 years ago
Closed 15 years ago
unable to build ssltunnel and some xpcom/test files due to CxxFrameHandler linkage
Categories
(Core :: XPCOM, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: jmaher, Assigned: hiro)
References
Details
Attachments
(2 files)
537 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
659 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This is due to bug 481579 where we use /NODEFAULTLIB by default. The problem is in files like ssltunnel.cpp we use STL for <vector> and <string> which internally require SEH. During link time, we don't have an exception handler available so we bail out. The solution which I am using is to extract stdexcpt.obj from libcpmt.lib and create a separate .lib: C:\PROGRA~1\MICROS~1.0\VC\ce\lib\armv4i>..\..\bin\x86_arm\lib.exe /extract:objr\armv4i\stdexcpt.obj /out:stdexcpt.lib libcpmt.lib Then we need to modify the makefile: http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/ssltunnel/Makefile.in We also need to do it here as well (nsIFileEnumerator.cpp won't link): http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/Makefile.in To include the stdexcpt.lib file that we created. I will update this bug with other edits that we require to get a build working. The final patch will be a set of makefile.in tweaks as well as a .lib file. Or we can generate the .lib file dynamically which is safer if we are going to be building on different sdk versions as time goes on.
Assignee | ||
Comment 1•15 years ago
|
||
Set libcmt.lib into EXTRA_LIBS expliciltly.
Assignee | ||
Comment 2•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #376176 -
Flags: review?(benjamin)
Reporter | ||
Comment 3•15 years ago
|
||
I verified these patches will allow --enable-tests to build on wince
Updated•15 years ago
|
Attachment #376176 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → ikezoe
Status: NEW → ASSIGNED
Assignee | ||
Updated•15 years ago
|
Attachment #376175 -
Flags: review?(jwalden+bmo)
Updated•15 years ago
|
Attachment #376175 -
Flags: review?(jwalden+bmo) → review+
Comment 4•15 years ago
|
||
Comment on attachment 376175 [details] [diff] [review] Patch for ssltunnel.exe rs=me if it works, I have zero knowledge about how non-trivial build processes work and would punt to anyone else if this weren't so small...
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 5•15 years ago
|
||
blassey, do you have any input on these patches? Otherwise I would like to get these checked in.
Comment 6•15 years ago
|
||
those look fine to me.
Assignee | ||
Updated•15 years ago
|
Assignee: ikezoe → nobody
Component: General → XPCOM
Product: Fennec → Core
QA Contact: general → xpcom
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → ikezoe
Comment 7•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8bdc45653040 http://hg.mozilla.org/mozilla-central/rev/32f180340f3a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Reporter | ||
Comment 8•15 years ago
|
||
verified with 1.9.2 build and winmo alpha3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•