487876 - update review queue age columns

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Nick Nguyen [:osunick]]

This was recently changed, but is not quite right:
https://addons.mozilla.org/en-US/editors/queue/nominated

The "Time in queue" column should show time since the add-on entered the nomination queue and not the time since the add-on was first nominated.  For example, an add-on that was recently denied nomination should have this counter reset when it gets resubmitted.

Once this fix is in place we can remove the "Add-on Age" column from the UI and database.

This column should also be removed from the Pending Queue and an identical "Time in queue" column added.  Default sort should be from oldest to newest.

Comment 1

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> The "Time in queue" column should show time since the add-on entered the
> nomination queue and not the time since the add-on was first nominated.  For
> example, an add-on that was recently denied nomination should have this counter
> reset when it gets resubmitted.

I tested this locally and looked at the code, and the behavior is already like you say. It is possible that it is still looking a little differently on production because for bug 483884, this was initialized for all add-ons as the same as their last modification date (cf. https://wiki.mozilla.org/Update:Developers/Database_Changes). For add-ons that are nominated from now on, the behavior will be as expected.

> Once this fix is in place we can remove the "Add-on Age" column from the UI and
> database.

All right, we can remove that column if you like (not from the db though).

> This column should also be removed from the Pending Queue and an identical
> "Time in queue" column added.  Default sort should be from oldest to newest.

That should be possible.

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #1)
> > This column should also be removed from the Pending Queue and an identical
> > "Time in queue" column added.  Default sort should be from oldest to newest.
> 
> That should be possible.

Actually, the "version created" time *is* the time-in-queue. When uploading an updated version to a public add-on, it is automatically put into the queue. If it is rejected, the author has to fix the problems and upload a new version which will likewise be put into the queue immediately.

I could re-label the existing column, but the time shown there should already be what you ask for.

Comment 3

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Renaming the column in the update queue and removing the add-on age from the nomination queue.

Comment 4

[Fred Wenzel [:wenzel]]

Committed to r24390, thanks.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/editors/queue/nominated:

* defaults to longest-time-in-review-queue
* no longer has "Add-on Age" column

https://preview.addons.mozilla.org/en-US/editors/queue/pending

* ditto, per above two items

Nick, mind giving these a glance too?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, per comment 5.