483884 - Change "age" to nomination age in editor tool, copy existing age column to "add-on age"

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Nick Nguyen [:osunick]]

This is basically two changes to the editor tool:

1. Add a column to show time in queue and rename to "time in queue"
2. Sorting will be based on "time in queue"

Comment 1

[u278084]

For clarification, this will only exist in the nomination queue. correct?

Comment 2

[Fred Wenzel [:wenzel]]

(In reply to comment #1)
> For clarification, this will only exist in the nomination queue. correct?

Yes, I would say so. Looking at the "updates" queue, the "age" column already represents the age of the update (= time in queue), not the overall age of the add-on.

Comment 3

[u278084]

Attachment: v1

Had some free time, so I decided to take this. (Actually, this ended up eating a few hours)

I couldn't see any way to do this without adding a new column in the database. The modified column sorta helps, but is updated with any change, so not entirely dependable. DB changes on next attachment.

Comment 4

[u278084]

Attachment: db changes

By default, I set nomination age to the last modified column. This is so we don't have weird "nomination age" values for all existing addons.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 370962 [details] [diff] [review]
v1

Thanks Ceasr.  Please change the sortBy line (192 after your patch) to 'nominationage' instead of 'created' also

Comment 6

[Wil Clouser [:clouserw]]

Also, before you check this in, can you rename "nominationage" to "nominationdate" everywhere when it refers to the db?  Otherwise the database column name doesnt' really make sense as it's holding a datetime.  Thanks.

Comment 7

[Nick Nguyen [:osunick]]

I am so, so happy this is making it in.  Thanks cesar!!

Comment 8

[u278084]

In r24190. Additionally to Wil's comments, I added the database change to remora.sql and changed the nomination age string to "Time in Queue" as per comment 1.

Comment 9

[u278084]

String changes went into r24191.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

It should read "Add-on Age", not "Addon Age" [sic].

Comment 11

[u278084]

Add-on fixed in r24200

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

String change in comment 11 verified on https://preview.addons.mozilla.org/en-US/editors/queue/nominated.

Cesar, can you please file an IT bug to have the script run so I can verify this on preview?  Thanks!

Comment 13

[Wil Clouser [:clouserw]]

(In reply to comment #12)
> String change in comment 11 verified on
> https://preview.addons.mozilla.org/en-US/editors/queue/nominated.
> 
> Cesar, can you please file an IT bug to have the script run so I can verify
> this on preview?  Thanks!

https://bugzilla.mozilla.org/show_bug.cgi?id=487326

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: http://www.grabup.com/uploads/1c3d151b9342e23cd20066bec2e61e72.png

(Tested on https://preview.addons.mozilla.org/en-US/editors/queue/reviews and https://preview.addons.mozilla.org/en-US/editors/queue/nominated.)