488109 - Win XP Folder List theme and icons

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

This is mostly about taking the icons and css from bug 483759 and porting over to the Win XP qute theme.

Andreas: I think we'll at least need a tango folder icon.  I can't really think of any other icons that would be missing from the gnomestripe theme work on this.

Comment 1

[Andreas Nilsson (:andreasn)]

Or we can use the folder icon from the Firefox XP theme that is closer to the native XP folder. Will assemble and attach.

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: folder icons

Here they are!

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: folder icons as patch

I haven't got a working window build setup to try this out in action, so let me know if there are any issues.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 377150 [details] [diff] [review]
folder icons as patch

The "new" icon is a lot more subtle, but I think it looks good. We still need the server.png icons updated.

david, do you mind reviewing this?

Comment 5

[Andreas Nilsson (:andreasn)]

Attachment: server icons

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: patch including both folder and server icons

Both in one patch

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 377387 [details] [diff] [review]
patch including both folder and server icons

david, more icon patches? :)

Comment 8

[David :Bienvenu]

Comment on attachment 377387 [details] [diff] [review]
patch including both folder and server icons

with this patch, archives/drafts/templates/sent all have the same icon (the one that looks like a blue postage stamp)

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: patch updated with messageHeader.css fix

That patch worked fine for me, the only thing I noticed later was that the messageHeader.css file was using the wrong moz-image-region coordinates.  This patch fixes the CSS errors.  

I'm not sure why you're seeing multiple sent folder icons for everything...

Comment 10

[David :Bienvenu]

the sent folder icons seem to be a flag issue on some of my imap special folders, not specific to this patch. Sorry for the false alarm...these icons just make it stand out more.

Comment 11

[David :Bienvenu]

the trash folder in the message pane looks a bit odd - I applied your updated patch, Bryan.

Drafts and templates look very similar

Comment 12

[David :Bienvenu]

Attachment: screen capture of odd looking trash icon

Comment 13

[David :Bienvenu]

Comment on attachment 378432 [details] [diff] [review]
patch updated with messageHeader.css fix

sorry, this does look OK - the fact that the last two patches had the same name messed up my weak hg queue fu.

Comment 14

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/375240d81a6a

Comment 15

[[:Aureliano Buendía]]

I think that the "news & blogs" new icon is missing: in my folder list I have again the old icon for news.

Comment 16

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #15)
> I think that the "news & blogs" new icon is missing: in my folder list I have
> again the old icon for news.

separate icons from the server and folder icons, i opened bug 494429 to get those in

Comment 17

[MrC]

I don't know if this is related, but over [url=http://forums.mozillazine.org/viewtopic.php?f=29&t=1262535]here in mozillazine[/url], I asked about a problem I'm seeing with the blue postage stamp appearing on some general IMAP sub-folders.  Could this be related?

Comment 18

[dreadnaut]

I don't think the stamp can represent the "Send email" action, or the "Sent email" folder.

First, it does not actually look like a stamp because it is empty. I see a blue painting in a frame - have you ever seen those icons that were used for image file formats on Windows XP? They had painting/stamps. At most, it says "gallery" to me.

Apart from my personal opinion, there are no stamps in electronic mail, so the idea is lost and the metaphor cannot catch: it does not suggest an action, it does not suggest that the folder contains emails thatI have sent ---that would mean that other people do not put stamps when they send emails to me, so why should I use stamps myself?

The only stamp I have seen around is the Mail.app icon, but the application uses a paper plane for Send and Sent Folder...

...which leads me to the "drafts" icon: Thunderbird has no paper planes, so why should it represent a draft with a partially folded piece of paper? Am I going to crumple that piece of paper, so "drafts" are something that I am likely to throw away soon? If there are no paper planes, there is no justification for using pre-folded paper.