488991 - Fix lib/pk11wrap/pk11merge.c warnings

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P4)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090417 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/9e06217fc471
 +http://hg.mozilla.org/comm-central/rev/...)

{
security/nss/lib/pk11wrap/pk11merge.c(684) : warning C4101: 'needCarry' : unreferenced local variable
security/nss/lib/pk11wrap/pk11merge.c(1119) : warning C4018: '<' : signed/unsigned mismatch
}

Comment 1

[tcma]

These warnings exist for NSS 3.11.4 but not NSS 3.11.5. 
The variable ‘needCarry’ was deleted in NSS 3.11.5.
There is no "signed/unsigned mismatch" warning on 32bit kubuntu 9.10.
$ gcc -v
Using built-in specs.
Target: i486-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 4.4.1-4ubuntu8' --with-bugurl=file:///usr/share/doc/gcc-4.4/README.Bugs --enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr --enable-shared --enable-multiarch --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.4 --program-suffix=-4.4 --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --enable-targets=all --disable-werror --with-arch-32=i486 --with-tune=generic --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu
Thread model: posix
gcc version 4.4.1 (Ubuntu 4.4.1-4ubuntu8)

Comment 2

[:Cykesiopka]

Bug 515870 removed needCarry.

(See http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/pk11wrap&command=DIFF_FRAMESET&file=pk11merge.c&rev1=1.5&rev2=1.6&root=/cvsroot )


Bug 671069 fixed the signed/unsigned issue.

(See http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/pk11wrap&command=DIFF_FRAMESET&file=pk11merge.c&rev1=1.8&rev2=1.9&root=/cvsroot )