please QA the Firefox 3.5 What's New page

VERIFIED FIXED in 3.5

Status

VERIFIED FIXED
10 years ago
6 years ago

People

(Reporter: jslater, Assigned: stephend)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

10 years ago
Hi all. The new & improved What's New page is now ready for QA. (note: we had QA'd the 3.1 version of this page in https://bugzilla.mozilla.org/show_bug.cgi?id=478776, but the page has changed pretty significantly for 3.5 so I thought it best to open up a clean, fresh bug).

This is both one of the highest priority pages to finish up soon (b/c it's an l10n requirement) and also one of the trickier pages. There are multiple states of this page depending on which version of the browser you're updating to...the version we want to work on now is the one for 3.5.0. 

Steven is going to weigh in soon with a more detailed explanation of what's what. Also, as you guys probably recall there was some confusion around the role of this page vs First Run during the 3.0 launch, so let's make sure we learn from that experience.

Thanks in advance for your help here.

Comment 1

10 years ago
Clicking on "latest and greatest version" link loads the personal.html page instead of mozilla main page.The download button in personal.html is not as obvious. This behavior may be due to A/B testing(though it was supposed to be turned off).

screencast:http://screencast.com/t/oPawtSiM
(Assignee)

Comment 2

10 years ago
(In reply to comment #1)
> Clicking on "latest and greatest version" link loads the personal.html page
> instead of mozilla main page.The download button in personal.html is not as
> obvious. This behavior may be due to A/B testing(though it was supposed to be
> turned off).
> 
> screencast:http://screencast.com/t/oPawtSiM

Krupa, that's because you're testing with 3.0.8.  This page should be tested in a 3.5 nightly.
I'm running a 3.5 nightly, but see the same content as at the beginning of that screencast; no real mention of what's new in 3.5.  Am I doing something wrong?
I've commented out some of the version checking (in r24755) so QA can see what the page will look like when 3.5 is actually the latest release. It might take a minute to update trunk (you should see "Firefox 3.5" logo colors rather than grey Georgia text in the heading).

(In reply to comment #3)
> I'm running a 3.5 nightly, but see the same content as at the beginning of that
> screencast; no real mention of what's new in 3.5.  Am I doing something wrong?

You should see the appropriate version of the page now, but it's mostly just the headline/sub-heading that changed - the rest of the page content is setup per the spec.
(Assignee)

Updated

10 years ago
Assignee: nobody → stephen.donner
(Assignee)

Comment 5

10 years ago
Page titles seem to be backwards?

https://www-trunk.stage.mozilla.com/en-US/firefox/3.5/whatsnew/
* "Welcome to Firefox"

https://www-trunk.stage.mozilla.com/en-US/firefox/3.5/firstrun
* "Firefox Updated"
(In reply to comment #5)
> Page titles seem to be backwards?
Fixed in trunk in r25057.
(Assignee)

Comment 7

10 years ago
I find the prepositional phrase "downloading to the fastest..." to be awkward; John?
(Assignee)

Comment 8

10 years ago
Also: Steven, would you please re-enable the version-checking (re: comment 4); thanks!
(Reporter)

Comment 9

10 years ago
(In reply to comment #7)
> I find the prepositional phrase "downloading to the fastest..." to be awkward;
> John?
Excellent catch...I totally agree. Let's remove the 'to', so it reads "...downloading the fastest..."

Thanks!
(In reply to comment #8)
> Also: Steven, would you please re-enable the version-checking (re: comment 4);
> thanks!

Done in r25104.

(In reply to comment #9)
> Excellent catch...I totally agree. Let's remove the 'to', so it reads
> "...downloading the fastest..."

Done in r25104.
1/ comment in firstun also apply here https://bugzilla.mozilla.org/show_bug.cgi?id=489432#c13

2/ the php code with a regex testing the version number should be externalized as an include or function and not exposed to localizers, this would also allow us to manage that code globally for all locales and all future minor releases

3/ 
<?php
  endif;
else:
?>
 this code looks strange to me (but I rarely use php alternate syntax) isn't an if: statement missing? I don't understand how we test the "unknown Firefox browser" case

4/ I would also really like the extra_headers section to be a common include for all whatsnew pages as we will have this code on 70 pages replicated with each minor release
(Reporter)

Comment 12

10 years ago
Steven, if the suggestions in comment #11 sound good to you, please make them as soon as you can. We need to get this page and First Run wrapped up soon.

Thanks!
(In reply to comment #11)
> 1/ comment in firstun also apply here
> https://bugzilla.mozilla.org/show_bug.cgi?id=489432#c13

Addressed here: https://bugzilla.mozilla.org/show_bug.cgi?id=489432#c15

The remaining issues will be addressed next.
Pascal,

I've made the changes requested for items 2, 3 and 4 in r25155, r25153 and r25156 respectively.
Pascal, extra PHP variable definitions have been moved into the external header files as well (request 4/). The $_page_title variable remains on the html page.
"Our Support page has plenty of answers,..."

I think it should be our "Support website" or "Support site"
(Reporter)

Comment 17

10 years ago
(In reply to comment #16)
> "Our Support page has plenty of answers,..."
> 
> I think it should be our "Support website" or "Support site"
Good catch. Let's make this read "Our Support site..." and then we can call this one finished. Same thing applies for the First Run page, btw.
(In reply to comment #17)
> Good catch. Let's make this read "Our Support site..." and then we can call
> this one finished. Same thing applies for the First Run page, btw.

Done in r25180.
(Reporter)

Comment 19

10 years ago
Safe to mark this as fixed?
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
verified fixed on https://www-trunk.stage.mozilla.com/en-US/firefox/3.5/whatsnew/
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.