490110 - Create a limit on how long usernames for registered users can be

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090420 Firefox/3.0
Build Identifier: 

In the forums, someone had an extremely long name that widened the forum index. We need to limit the length of usernames.

Reproducible: Always

Comment 1

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Attachment: Screenshot of long username

Comment 2

[Paul Craciunoiu [:paulc]]

I'll look into it, see if there is actually a limit already built in.

If not, I'll make this an admin pref. A sensible default sounds like 15-20 characters. David, Laura: what do you think?

Comment 3

[Majken Connor [:Kensie]]

there is a pref, it's set to 50.

Comment 4

[David Tenser [:djst]]

20 sounds like a reasonable limit. What happens with existing accounts with longer user names if we change this though?

Comment 5

[[:Cww]]

1129 such logins ... almost all are e-mail addresses.

Comment 6

[[:Cww]]

1129 logins longer than 20.  Only 73 have _ever_ done anything that is tracked in the actionlog (posted/answered a forum thread, contributed to the KB).  25 have done those things since 2009-01-01.  It's such a small number that we can go through the list manually and e-mail them if this is going to be a problem.

These are for registered users.

The screenshot above is for a not-registered user.  We won't be truncating that field in the tiki_comments table so I think as long as we limit that field size (which I don't think is specified by the pref but correct me if I'm wrong) we should be ok in that case as all usernames from here on out will be short.

Comment 7

[Paul Craciunoiu [:paulc]]

Ooo, good point Cheng. I think we should limit that field for anonymous users. That's actually more important than the username limit.

I just changed the pref to 20 on stage.

Comment 8

[Paul Craciunoiu [:paulc]]

This too is ready for testing on stage. I tested a 25 long username and couldn't register. We can change it on prod once testing of stage is approved.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> This too is ready for testing on stage. I tested a 25 long username and
> couldn't register. We can change it on prod once testing of stage is approved.

I tested:

* 25: failed
* 20: passed
* 21: failed

Verified FIXED on https://support-stage.mozilla.org/tiki-register.php; Paul, want to resolve this as FIXED -- we'll then verify on production; thanks!

Comment 10

[Paul Craciunoiu [:paulc]]

This is ready to be changed on prod, and doesn't need any code push.

Comment 11

[Chris Ilias [:cilias]]

If I understand this correctly...
* We need to set this on prod. (I assume it's "Maximum username length:" on <https://support.mozilla.com/tiki-admin.php?page=login>, but it's also set to 50 on stage. Is that just because there was a recent sync?)
* We need to email registered users who exceed the limit (does that need to be done before changing the setting on prod?)
* We leave this bug open for limiting the field for non-registered users.

Comment 12

[Chris Ilias [:cilias]]

Paul verified on IRC that the URL in comment 11 is correct, and that we don't have to email registered users who exceed the limit before changing prod.

"Maximum username length:" is now set to 20 on prod.

Comment 13

[Paul Craciunoiu [:paulc]]

Next up is limiting input length in anonymous fields.

Comment 14

[Paul Craciunoiu [:paulc]]

Filed bug 502862 for comment 13 (comment 11 item #3)

Comment 15

[Tom Ellins [:TMZ]]

Verified on prod. Limit 20