xpcshell-tests: replace head files by setup functions & imports?

UNCONFIRMED
Unassigned

Status

Testing
XPCShell Harness
--
enhancement
UNCONFIRMED
9 years ago
a month ago

People

(Reporter: sgautherie, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

9 years ago
While reviewing bug 384339, Jeff wrote (iirc):
{
frankly, if I were to do it again I'd not have head/tail files; you get a setup function and a teardown function, and you put whatever you want in them (or not define them if not necessary)
and you could load files if you wanted to keep common functionality separate
make the dependencies explicit, not implicit by location
that's long-term, not for now
}
(Reporter)

Updated

9 years ago
Depends on: 503613
Bug 503613 has removed the tail file functionality, so updating title.

I agree with comment 0 that it'd be good to make the dependencies explicit, this would be especially good for helping eslint to work better. For that, I think we really need bug 1308512 to give us a better module/file import system.
Depends on: 1308512
Summary: xpcshell-tests: replace head+tail files by setup+teardown functions → xpcshell-tests: replace head files by setup functions & imports?
You need to log in before you can comment on or make changes to this bug.