Created attachment 374907 [details] [diff] [review] WIP 1 This is a very basic implementation (and still a WIP) of playing sounds when a download completes.... (formatting slightly funky as I just had to hand-edit a diff due to including part of the bits meant for here in another patch)
You'd want to check the play sound pref every time you download for a start.
Created attachment 403863 [details] [diff] [review] Proposed patch Since we can't reasonably expect Callek to finish the patch soon... * Removed comment markers in pref-downloads.js * Add code to disable sound controls on startup * Uncommented elements in pref-downloads.xul (sadly not as easy as .js) * Add code to nsSuiteGlue.js to actually play the sound (very loosely based on Callek's patch)
Comment on attachment 403863 [details] [diff] [review] Proposed patch You have a clash of accesskeys "a" is used in two places. You could change "Play a sound" to "P" and then have "Show an alert" as "S"
Attachment #403863 - Flags: review?(iann_bugzilla) → review-
Created attachment 403905 [details] [diff] [review] With locale changes
Pushed changeset 16d24cd30915 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.