490785 - RTL support for the new category landing page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

This patch implements RTL support for the new category landing page.  I will also attach the new sprite.png file which adds two RTL arrows used in this patch.

Comment 1

[(no longer active)]

Attachment: new sprite.png

Comment 2

[Ryan Doherty (:rdoherty)]

Comment on attachment 375151 [details] [diff] [review]
Patch (v1)

Patch looks good. Sprite can't be used though because the colors don't match the current one. But I can easily create it from the psd.

Comment 3

[Ryan Doherty (:rdoherty)]

Comment on attachment 375152 [details]
new sprite.png

Colors don't match current sprite.

Comment 4

[Ryan Doherty (:rdoherty)]

r25117 , will commit new sprite soon.

Comment 5

[Ryan Doherty (:rdoherty)]

Sprite in r25122.

Thanks Ehsan, you rock!

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/he/firefox/browse/type:1/cat:4 and https://preview.addons.mozilla.org/fa/firefox/browse/type:1/cat:4.

smontagu in #developers mentioned that the login link isn't in the right place -- separate bug, though.

Comment 7

[(no longer active)]

Yes, the position of the login link is wrong, but that's part of a much bigger problem, and that is the fact that the RTL support of all AMO pages is partial (i.e. some parts are mirrored, and some are not).  I plan to overhaul the RTL support on the whole site at some point, but it's rather a large project, which may be solved better in smaller chunks (such as this bug).  :-)

BTW, I noted some placement problems in the categories drop-down div; should I file a new bug on that or reopen this one?  (Not sure how bug management works in the AMO land...)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #7)

<snip>

> BTW, I noted some placement problems in the categories drop-down div; should I
> file a new bug on that or reopen this one?  (Not sure how bug management works
> in the AMO land...)

Smaller, more-specific bugs are almost always preferred; thanks for your help!

Comment 9

[(no longer active)]

(In reply to comment #8)
> > BTW, I noted some placement problems in the categories drop-down div; should I
> > file a new bug on that or reopen this one?  (Not sure how bug management works
> > in the AMO land...)
> 
> Smaller, more-specific bugs are almost always preferred; thanks for your help!

Sure, filed bug 490882.

Comment 10

[Wil Clouser [:clouserw]]

(In reply to comment #7)
> Yes, the position of the login link is wrong, but that's part of a much bigger
> problem, and that is the fact that the RTL support of all AMO pages is partial
> (i.e. some parts are mirrored, and some are not).  I plan to overhaul the RTL
> support on the whole site at some point, but it's rather a large project, which
> may be solved better in smaller chunks (such as this bug).  :-)
> 

For the record, the ltr and rtl CSS is being overhauled for the facelift AMO is getting next month.  The contractors (clearleft) doing the work have assured us rtl is being taken seriously and we'll continue to verify that as we go.

Comment 11

[(no longer active)]

(In reply to comment #10)
> For the record, the ltr and rtl CSS is being overhauled for the facelift AMO is
> getting next month.  The contractors (clearleft) doing the work have assured us
> rtl is being taken seriously and we'll continue to verify that as we go.

That's great to hear.  I'd appreciate if you keep me in the loop so that we can ensure the quality of RTL support in the facelift.