492149 - deleting msg from smart folder causes hdr area to get cleared

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

If you delete a message from a smart folder (or any cross-folder saved search), we hide the hdr pane, display the message body, and then show the hdr pane. 

The fix is to set m_deletingRows to true when deleting from a saved search, and to add the deleted indices to mIndicesToNoteChange.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 376511 [details] [diff] [review]
proposed fix

>       if (msgHdr)
>         RememberDeletedMsgHdr(msgHdr);
>+            // if we are deleting rows, save off the view indices
>+      if (m_deletingRows)
>+        mIndicesToNoteChange.AppendElement(indices[i]);
>+
>     }

The indentation in this function is weird, but that comment is definitely wrong ;-)

>     if (!deleteStorage)
>       rv = ProcessRequestsInOneFolder(window);
>     else
>       rv = ProcessRequestsInAllFolders(window);
>     return rv;
> }

Shouldn't you be setting m_deletingRows to false if either of these fail - in a similar way to nsMsgDBView::DeleteMessages ?

Comment 2

[David :Bienvenu]

Attachment: fix addressing Standard8's comments

good catch about the failure case. I cleaned up the indentation in that method as well...

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 376710 [details] [diff] [review]
fix addressing Standard8's comments

>+ // remember the deleted messages in case the user undoes the delete,
>+ // and we want to restore the hdr to the view, even if it no
>+ // longer matches the search criteria.
>+  for (nsMsgViewIndex i = 0; i < (nsMsgViewIndex) numIndices; i++) 

nit: comment not indented quite right now.

>+  {
>+    nsCOMPtr<nsIMsgDBHdr> msgHdr; 
>+    (void) GetMsgHdrForViewIndex(indices[i],getter_AddRefs(msgHdr));

nit: space after comma please.

r/sr=Standard8 with those fixed.

Comment 4

[David :Bienvenu]

fix checked in with nits addressed.