1432537 - Delete message from advanced Search Messages results doesn't update results list view

Status: NEW

(Thunderbird :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

I hope someone else can riff on these steps to get something 100% reproducible.

+++ This bug was initially created as a clone of Bug #515400 +++ (open: Gloda/Global search list view doesn't update after delete)
+++ Bug 515400 was created as a clone of Bug #500083 +++ (fixed: "Advanced" search messages list view doesn't update after delete)

While testing bug 557990 I developed a somewhat reproducible testcase (at least for me) on work desktop with 58.0b1. bienvenu in bug 500083 states global search facet results uses the same view code, so I hope fixing this helps bug 515400.

STR
1. open advanced search ctrl+shift+f
2. change Subject dropdown to From (but perhaps this is not a necessary step)
3. attempt search (alt+S or click search) with no search term to get zero results (of course)
4. fill in the search term field after "contains"
5. attempt search (alt+S or click search)
6. in the results list click on one message and delete

Actual Results
 like bug 515400 comment 7, message is deleted but the message list view is not updated

Expected results
 view for list of messages is updated

Skip step 3 and I always get expected results. (coincidence?)


started nightly, couldn't reproduce in a few attempts (but that's hardly enough to say the problem is gone - and I doubt it is gone)  Went back to 58.0b1. After several attempts I eventually reproduced but not with 100% success (maybe 50%) After step 1 it either fails or doesn't).   So perhaps other steps are needed to help cause this bug at 100%.  Scenarios that might be involved - using a message that has >1 message in thread (or just one message in thread), virtual folders, etc.

Comment 1

[Jorg K (CEST = GMT+2)]

Maybe Alta88 might be able to take a look, since it's in the view area.

Comment 2

[Wayne Mery (:wsmwk)]

in two attempts I can't reproduce using 60.0b7 :(

Eckard, can you reproduce with any of the mentioned versions, 58.0b1 and 60 beta?

Comment 3

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #0)
> I hope someone else can riff on these steps to get something 100%
> reproducible.
> 
> +++ This bug was initially created as a clone of Bug #515400 +++ (open:
> Gloda/Global search list view doesn't update after delete)
> +++ Bug 515400 was created as a clone of Bug #500083 +++ (fixed: "Advanced"
> search messages list view doesn't update after delete)
> 
> While testing bug 557990 I developed a somewhat reproducible testcase (at
> least for me) on work desktop with 58.0b1. bienvenu in bug 500083 states
> global search facet results uses the same view code, so I hope fixing this
> helps bug 515400.
> 
> STR
> 1. open advanced search ctrl+shift+f
> 2. change Subject dropdown to From (but perhaps this is not a necessary step)
> 3. attempt search (alt+S or click search) with no search term to get zero
> results (of course)
> 4. fill in the search term field after "contains"
> 5. attempt search (alt+S or click search)
> 6. in the results list click on one message and delete

Wayne, in view of bug 557990, comment 17, we need more precise STR here:
Are you using keyboard's [DEL] key or the dialog's [Delete] button?

> Actual Results
>  like bug 515400 comment 7, message is deleted but the message list view is
> not updated

- (How) did you verify that the message has been deleted? Can you include that check in STR please?
- Maybe you could also add STR how to double-check for details as to how the message list view has not been updated? Does it update upon mouse move, iow, is this a screen update issue?
- on which OS and OS version are you seeing this? If it's about row invalidation/screen update, any details about your system's graphics that we should know?

Also, does this fail for you on POP or IMAP? Could IMAP connection problems play into this?

I'm deliberately nitpicking because it's so easy to assume details which haven't been mentioned or verified and then we're getting confused about what really happens in these bugs.
This bug sounds much like bug 1468940 until where you say that messages actually do get deleted, but only your result list doesn't update to remove the respective list item.

> Expected results
>  view for list of messages is updated
> 
> Skip step 3 and I always get expected results. (coincidence?)

Using [Delete] button to work around bug 1468940, I cannot reproduce this bug either way, on Windows 10, TB 62.0a1 (2018-06-14) (64-bit).

Comment 4

[Wayne Mery (:wsmwk)]

I always use keys

Comment 5

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #4)
> I always use keys

I'm trying to help reproduce your bug, so can you please answer my other questions, too?

Comment 6

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #4)
> I always use keys

And even that unfortunately does NOT answer my question:

> Are you using keyboard's [DEL] key or the dialog's [Delete] button?

So using keys, you could use [DEL] key or Alt+D to press the [Delete] button, which makes all the difference.
So again, which keys are you using?

Comment 7

[Wayne Mery (:wsmwk)]

[del] key only

imap or pop would not make a difference - it's a view issue.
how do we know a message is deleted - surely by checking the underlying folder :)

currently I don't have anything further as I cannot reproduce.

Comment 8

[Eckard Berberich]

> Eckard, can you reproduce with any of the mentioned versions, 58.0b1 and 60
> beta?
No, I can't reproduce the issue with TB 60.0b7 (macOS 10.13.5).