492271 - "All Add-ons have been disabled in safe mode" is misleading in safe mode

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[hogballs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10

The add on message box includes extensions, themes and plug-ins.  When you view this in safe mode it includes the statement above even if you are on the plug-in tab.  Plug-ins are not disabled in safe mode. 

Reproducible: Always

Steps to Reproduce:
1.Go into safe mode
2.Click on Tools --> Add-ons (in Windows)
3.Click on the Plug-in tab
Actual Results:  
Reads "All Add-ons have been disabled in safe mode"

Expected Results:  
Should read "All Themes and Extensions have been disabled in safe mode"

I am assuming that this also exists in the branch/trunk builds but don't know.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Plugins aren't add-ons but remembering several discussions with users most of them don't know the difference. So it looks like a nice fix.

Comment 2

[hogballs]

Easy one too ;)

Comment 3

[Dave Townsend [:mossop]]

Can't fix this for 3.5 and I'd really prefer to just see bug 342333 fixed instead

Comment 4

[hogballs]

So would I but it does not seem likely that will happen in the near future.  This is a very mild support pain in the butt that would be an easy fix until the real fix comes along.

Comment 5

[Dave Garrett]

(In reply to comment #1)
> Plugins aren't add-ons but remembering several discussions with users most of
> them don't know the difference.

They aren't extensions but they certainly are add-ons and are referred to as such in many places. Add-ons is a generic term encompassing extensions, themes, plugins, search plugins, dictionaries, and language packs. If it's listed in the Add-ons Manager and/or on addons.mozilla.org then it's an add-on, seeing as the word "add-on" is used to describe it. ;)

Comment 6

[[not reading bugmail]]

This is still a problem with the new AOM in Fx4.

Comment 7

[[not reading bugmail]]

Is this a strings issue, I think we're past that cutoff again.

(In reply to comment #4)
> So would I but it does not seem likely that will happen in the near future. 
> This is a very mild support pain in the butt that would be an easy fix until
> the real fix comes along.

Fx4 currently shows a Disabled status on each Extension and Theme listing, but Plugins do not and the message is still at the top.  I wonder though if the message could be hidden instead.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

While bug 342333 doesn't seem to be fixable in a short term, could we simply hide the bar when the plugins category is selected? It would make the state of the plugins more trustworthy.

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

(In reply to comment #7)
> Fx4 currently shows a Disabled status on each Extension and Theme listing, but
> Plugins do not and the message is still at the top.  I wonder though if the
> message could be hidden instead.

And this is what this patch does. It should help clear up some confusion until bug 342333 is fixed.

This patch also hides the safemode warning when the details pane is still loading, to avoid flashing it (as there's no way to tell what type of addon will be shown in the details pane, until the async call completes).

No tests since we can't run mochitests in safemode (and even then, half the changes still wouldn't be testable). Litmus ftw.

Comment 11

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/50b3455b84ba

As I mentioned in comment 10, we'll need a litmus test here. Just needs to check that the safemode warning message doesn't show up when viewing either the plugins list, or the detail view of a plugin.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101207 Firefox/4.0b8pre

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Manual test covered by:
https://litmus.mozilla.org/show_test.cgi?id=15315

Comment 14

[Graham Perrin]

Attachment: Screenshot of the misleading text

In lieu of:

ⓘ All add-ons have been disabled by safe mode

– try less misleading:

ⓘ Add-ons of this type are disabled in safe mode