492964 - Get New Messages for <selected account> is trying to get messages for all the accounts when using global inbox

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Vlado Valastiak [:wladow]]

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1b5pre) Gecko/20090514 Shredder/3.0b3pre

1. Use the toolbar button for getting new messages or choose File -> Get New Messages for
2. Select one of your accounts
3. Watch the status bar - Shredder is checking all your accounts for new messages instead of just the selected one

-> regression

Comment 1

[Ludovic Hirlimann [:Usul]]

If you select the account after having asked to fetch email - the default is to check all email accounts.

> -> regression

When did it regress ?

Comment 2

[Vlado Valastiak [:wladow]]

(In reply to comment #1)
> If you select the account after having asked to fetch email - the default is to
> check all email accounts.
Sure, but I'm talking strictly about a single account. Maybe the first step isn't that clear - by "use the toolbar button" I meant to open its dropdown menu so you can choose an account 

> > -> regression
> 
> When did it regress ?
Sorry, too busy right now to look for a regression range, but it regressed lately for sure. Beta 2 works as expected as well.

Comment 3

[Joe Sabash [:JoeS1]]

I don't seem to be able to reproduce this using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090514 Lightning/1.0pre Shredder/3.0b3pre ID:20090514031430

Winxp sp3

Comment 4

[WADA:World Anti-bad-Duping Agency]

Vlado Valastiak, is there any error message which relates to the problem at Error Console?

Comment 5

[Magnus Melin [:mkmelin]]

Bug 296655 had to re-factor code for the getting mail for account part, so maybe I messed up something there...

Comment 6

[Vlado Valastiak [:wladow]]

(In reply to comment #4)
> Vlado Valastiak, is there any error message which relates to the problem at
> Error Console?
Nope

(In reply to comment #5)
> Bug 296655 had to re-factor code for the getting mail for account part, so
> maybe I messed up something there...
Yeah, it seems so.

Regression window:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090509 Shredder/3.0b3pre build 20090509031542
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090510 Shredder/3.0b3pre build 20090510031449

and that's the time slot when bug 296655 landed

Comment 7

[Magnus Melin [:mkmelin]]

Sorry, can't reproduce this using
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090514 Lightning/1.0pre Shredder/3.0b3pre

Have you made sure all extensions are disabled?

If that's not the problem, do you have more backgroud info to reproduce?

Comment 8

[Vlado Valastiak [:wladow]]

It's strange that no one is able to reproduce this. The only ext I have is DOMi and it's disabled for now. I can see this bug with -safe-mode too.

I noticed this is related to POP3 accounts. I've got 2 IMAP accounts, 5 POP3 accounts, newsgroup and feeds accounts as well. This is happening only if I want to check a POP3 account - if I click on one of those five, Shredder will check all of them.
Or in other words it doesn't need to be necessarily related to POP3, but to Local Folders - all my POP3s are using global Inbox while the other accounts have their own folders.

Comment 9

[Magnus Melin [:mkmelin]]

Ah, global inbox is the key!

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Moved the GetNewMessagesInFolders functionality into mailWindowOverlay.js as it was only ever called from there.

The basic problem was that where GetNewMessagesInFolders([inboxFolder]); was called it needed the server to be another server than inboxFolder.server

Comment 11

[Magnus Melin [:mkmelin]]

changeset:   2661:0f818e54a43b
http://hg.mozilla.org/comm-central/rev/0f818e54a43b

->FIXED

Comment 12

[Vlado Valastiak [:wladow]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1pre) Gecko/20090521 Shredder/3.0b3pre

Thanks for the fix.