493221 - "URL Not Valid" alert opening message with invalid Content-Base header

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Reader UI, defect)

Description

[Jeff Grossman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US) AppleWebKit/530.10 (KHTML, like Gecko) Chrome/2.0.181.0 Safari/530.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090515 Lightning/1.0pre Shredder/3.0b3pre

When opening up my daily accuweather.com alert forecast e-mail, it displays the body for a second and then immediately gives an invalid url message.

Reproducible: Always

Steps to Reproduce:
1.  Open E-mail From accuweather.com
2.  The body will display for a second and then give an invalid url message.
3.
Actual Results:  
The message was not viewable.

Expected Results:  
The body of the message should have stayed in the window.

Comment 1

[Jeff Grossman]

Attachment: Copy of e-mail with problem.

I am including a copy of the e-mail.  I have removed any personal information from the headers.

Comment 2

[Magnus Melin [:mkmelin]]

Content-type: text/html; charset=us-ascii
Content-Disposition: inline; filename="accuwx.htm"

You can see it if you turn on View | Show attachments inline

Comment 3

[Jeff Grossman]

I already have View | Show attachments inline and I am unable to view the attachment.  I have always had that setting on, and I have been able to see this daily e-mail until about 3 weeks ago.  At that time I started to receive the error message:

The URL is not valid and cannot be loaded.

Comment 4

[Magnus Melin [:mkmelin]]

I don't know why you would get that message by *only* reading a mail. When exactly do you get it? 

The mail displays fine for me (with inline attachments showing). 

Have you disabled all extension? (thunderbird.exe -safe-mode)

Comment 5

[Jeff Grossman]

I get it within 1-2 seconds after the window opens.  It says Loading Message in the status line.

I just tried it in safe-mode, and the mail displays correctly in the preview pane, but not when I open up the message in a new window.  I don't use the preview pane normally.  I double click on each message and open them up in a new window.

I have also been tracking bug number 486954.  I think this problem started right about the time that bug was closed.  Any relation or just a coincidence?

Comment 6

[Magnus Melin [:mkmelin]]

I guess it's possible bug 486954 could affect it somehow. You could always try a build from the day before it.

Comment 7

[Jeff Grossman]

Okay, so I was incorrect in regards to bug 486954.  Also, it does not appear to be related to bug 182627 either.

The e-mail loads up correctly with build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090501 Lightning/1.0pre Shredder/3.0b3pre

But, beginning with build:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b5pre) Gecko/20090502 Lightning/1.0pre Shredder/3.0b3pre

it no longer displays.  I am going to open this bug back up.

Comment 8

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-05-01+03%3A00%3A00&enddate=2009-05-02+03%3A00%3A00

Just test landings on mozilla-1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?startdate=2009-05-01+03%3A00%3A00&enddate=2009-05-02+03%3A00%3A00

Comment 9

[Jeff Grossman]

I am not a programmer so I have no idea what those changesets mean or what I am looking at.  But, looking through them, I would guess that the following is what created the problem.  But, it is strictly a guess on my part.

bug 438429: meta bug to fix several RSS Summary/Web Page bugs; r=standard8, sr=bienvenu
author	Myk Melez
Fri May 01 11:27:15 2009 -0700 (at Fri May 01 11:27:15 2009 -0700)
changeset 2520	ed1011d1e791
parent 2519	84d75e481b54
child 2521	6aedf9644c2d
pushlog:	ed1011d1e791
bug 438429: meta bug to fix several RSS Summary/Web Page bugs; r=standard8, sr=bienvenu

Comment 10

[Magnus Melin [:mkmelin]]

Yup, I see this too on linux. I verified this is a regression from bug 438429.

Comment 11

[alta88]

this is due to:

Content-Base: "http://www.accuweather.com"

the issue is how to identify a feed message, whether it is in the News (feed) folder or not (copied/moved), and content-base is used for historical rss reasons.  so apparently this email sender adds the Content-Base header thus feed is assumed, yet it is not a feed.  per rfc, i think content-base is sort of free form.

if pref rss.show.content-base is set to 1 (global option show feed summary in new window) this may be avoided, but is not a real solution.

Comment 12

[alta88]

actually, the real reason for the error alert (the web page would just be loaded even though it's not a feed) is the malformed url due to the double quotes...

so unless Tb is going to scrub urls in content-base, this is an error on accuweather's part.

the default value for the above pref should be set to 1 or 2 to minimize bad url issues in general, and avoid unexpected behavior for the rare non feed msg.

Comment 13

[Magnus Melin [:mkmelin]]

This is now WFM, likely due to bug 522645.