493237 - Enable crash stack display on leaktest builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Benjamin Smedberg]

The leaktest builds currently don't run minidump_stackwalk on crashes. They are using automation.py, so this is probably as simple as making sure we run `make buildsymbols` on them and then make sure that MINIDUMP_STACKWALK is set properly in the environment: this is the same thing we do for unittest machines.

Comment 1

[Aki Sasaki (not active)]

I believe the leak test machines will be going away in favor of debug unit test machines, so that may cover this. (Correct me if I'm mistaken.)

Comment 2

[Aki Sasaki (not active)]

I'm going to future this as the work on debug unit tests should cover it/take precedence.

Comment 4

[Chris AtLee [:catlee]]

We still need this for the leak tests.

Comment 5

[Chris AtLee [:catlee]]

Attachment: Add MINIDUMP_STACKWALKER for leak tests, and make check.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 421977 [details] [diff] [review]
Add MINIDUMP_STACKWALKER for leak tests, and make check.

Looks fine, r+

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 421977 [details] [diff] [review]
Add MINIDUMP_STACKWALKER for leak tests, and make check.

changeset:   575:574d8732fc8c

Comment 8

[[e-mail] (:bhearsum)]

I reconfig'ed pm01 and pm02 for this.

Comment 9

[[e-mail] (:bhearsum)]

I don't know how to test this fix, so I'm going to assume it worked. I'll watch out for leak test crashes this week and re-open if they're still stackless.