Status

VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: fligtar, Assigned: smccammon)

Tracking

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
Sorry for lateness in filing this bug -- I forgot that in Clearleft's designs the search field isn't obvious. I would bump it to the next milestone, but I think it's a blocker for the initial launch, otherwise no one will be able to find collections they're looking for.

In the dropdown of available search categories, "all collections" should be an option at the very end of the list. This option should be selected when on /collections pages. Additionally, the "search for add-ons text" pre-populated should be "search for collections"

Collections should be searchable on name and description, and the results should be shown in a grid just like the directory, titled "Collection Search Results". The sort dropdown should remain, but the tabs can go away.

There should also be breadcrumbs to get back to the main Collection Directory page.
(Assignee)

Updated

10 years ago
Assignee: nobody → smccammon
Status: NEW → ASSIGNED
(Assignee)

Comment 1

10 years ago
Posted patch Patch, v1Splinter Review
Attached patch gets things done.

Sorting is pending on bug 494075 implementation.
Attachment #379298 - Flags: review?(clouserw)
Attachment #379298 - Flags: review?(clouserw) → review-
Comment on attachment 379298 [details] [diff] [review]
Patch, v1

- the "add to favorites" links are implemented now
- Shouldn't need this anymore:  $this->publish('cssAdd', array('forms'));
- I don't think bigHeader and bigHeaderText are used in amo2009
- the advanced search queries don't apply to the search
(Assignee)

Comment 3

10 years ago
The attached patch builds on attachment 379298 [details] [diff] [review].

In addition to the requested changes, I added a full-text search table for robustness.

Most advanced search fields are now disabled for a collection search. Appid and perpage fields will apply once the advanced search form is working again. (I'll file a bug on this if there isn't one already)
Attachment #379699 - Flags: review?(clouserw)
Comment on attachment 379699 [details] [diff] [review]
Advanced fields disabled + fulltext search

Go ahead and commit this so we can start playing with it.  Before the bug is resolved though:

1) I've got an add-on named "tasdfasdfftasdfasdfftasdf" and searching for "asdf" doesn't match it (it matches others).  Something with substring?

I'll double check the advanced search thing once wenzel lands the patch for it - it's already written.
Attachment #379699 - Flags: review?(clouserw) → review+
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)

> 1) I've got an add-on named "tasdfasdfftasdfasdfftasdf" and searching for
> "asdf" doesn't match it (it matches others).  Something with substring?

The current implementation does a full-text search on name and description of publicly listed collections for the selected application.

If "tasdf..." is a collection, maybe it is associated with a different app or not listed? It may be desirable to include unlisted collections that are owned/created/subscribed to by the current user.

If "tasdf..." is an add-on as mentioned, is it desirable to search add-ons and return all the collections they are in?
"tasdf..." is a publicly listed collection for the Firefox app.  (You can see it on clouserw.k.m.o if you want)

> If "tasdf..." is a collection, maybe it is associated with a different app or
> not listed? It may be desirable to include unlisted collections that are
> owned/created/subscribed to by the current user.
I'm not worried about this for now.

> If "tasdf..." is an add-on as mentioned, is it desirable to search add-ons and
> return all the collections they are in?
No.

Fligtar: Also, I think having "all collections" at the bottom of the search dropdown really looks like an afterthought, but I don't have a different recommendation.
(Assignee)

Comment 7

10 years ago
Full-text indexes can only be used to match search terms at the start of words. Because both collection and add-on search use only the full-text index, neither currently match text in the middle or at the end of a word.

We could add a  LIKE '%word%' clause to these queries, but then your performance dies.
Hm, I hadn't noticed that.  Since that's how the rest of the searches work on the site I'm comfortable leaving it as is then.
(Assignee)

Comment 9

10 years ago
r26465 committed

A recent update broke "add to favorites". I'll get a new patch for that along with some tests.
(Assignee)

Comment 10

10 years ago
Patch adds sorting of results and some tests.

The view code still lags collections/listing which is in active development. Sometime (soon?) some common elements should be factored out. I'll file a bug.
Attachment #380468 - Flags: review?(clouserw)
Attachment #380468 - Flags: review?(clouserw) → review+
(Assignee)

Comment 11

10 years ago
r26618
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Refactored in r26826 and r26827.
Depends on: 495878
Verified FIXED; this is in: https://preview.addons.mozilla.org/en-US/firefox/search?q=stephen&cat=collections.

We'll file new bugs for anything we might find.
Status: RESOLVED → VERIFIED
removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.