494195 - Show a prominent message if someone tries to install without Firefox

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Wil Clouser [:clouserw]]

When the application is "Firefox" for non Firefox users, the "add to Firefox" button should trigger a lightbox with a message to install firefox:

To install [application] and thousands of other Firefox add-ons, get Firefox, a free and open web browser from Mozilla.  To learn more about Firefox and how it can make your internet experience better, click the button below.

    [Learn More]

Th "Learn More" link should go to "getfirefox.com" and open in a new tab/window.  It should also be some kind of pretty button.

This shouldn't affect people who right-click on the button to download the add-on in another browser.

Comment 1

[Nick Nguyen [:osunick]]

this is what you get for going to the beach

Comment 3

[Fred Wenzel [:wenzel]]

Ryan, do I need to block this on bug 498825?

Comment 4

[Ryan Doherty (:rdoherty)]

(In reply to comment #3)
> Ryan, do I need to block this on bug 498825?

Yeah, I'm rewriting the JS now, which is where this would happen.

Comment 5

[Fred Wenzel [:wenzel]]

I figured as much, thanks. I'll wait until your rewrite lands.

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

This adds a message for all Firefox add-ons if the user is not using Firefox and left-clicking the install button. Like for most things, the all-versions page is exempt.

Comment 7

[Fred Wenzel [:wenzel]]

Attachment: Screenshot

Here's a screenshot of what you are supposed to see.

Comment 8

[Jeff Balogh (:jbalogh)]

Contributions is going to have a modal dialog that looks like this: http://img.skitch.com/20091023-1b1fy2i57r951jkb9srcf72k19.jpg

We should be consistent with our boxes.  If you don't want to figure out the styles for that box (totally fine!), file a bug for me and I'll fix it once I have the CSS.

Comment 9

[Fred Wenzel [:wenzel]]

I'll round the corners for now, but it's probably best if you adapt the style in the process of making the contributions overlay. Docs are here: http://dev.iceburg.net/jquery/jqModal/

I filed bug 524136. Thanks!

Oh, and I made the corners round now (just because we can).

Comment 10

[Wil Clouser [:clouserw]]

Comment on attachment 408026 [details] [diff] [review]
Patch, rev. 1

Now that I see this in action, it's very jarring.  I'm not sure I like it. :)

Please add an L10n comment to 'To install %1$s and thousands...' to explain %1$s

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #10)
> Now that I see this in action, it's very jarring.  I'm not sure I like it. :)

Hehe. We can remove it if it turns out to be all too obnoxious.

> Please add an L10n comment to 'To install %1$s and thousands...' to explain
> %1$s

All right. All of the above: r54150.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

I couldn't get this to work in any of the non-Firefox browsers I tried, on preview.

Comment 13

[Fred Wenzel [:wenzel]]

Looks like something isn't built correctly on preview. Isn't it supposed to run the build script automatically?

Comment 14

[Fred Wenzel [:wenzel]]

Argh, I borke it by missing a comma. Fixed in r54337, and apologies. Please test again, Stephen!

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening; in at least IE 8, on any category-landing page (such as https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:71), clicking on "Download Now" puts up the roadblock with some funky z-index (it appears _behind_ the search textfield, and the "Learn More" button isn't clickable).

Also, I agree with Wil that this doesn't seem like a very well designed/useful feature -- we could/should do upsell in a different way.

Comment 16

[Nick Nguyen [:osunick]]

If you guys have ideas on doing upsell in a different way, I'm all ears.  I think that this is still a better experience than having an IE user download an XPI that they don't know how to use.  Maybe the popup just needs some chowse mclovin?

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of IE 8, for the record

Comment 18

[Fred Wenzel [:wenzel]]

Looks like we're not ditching or changing this at the moment, so I am going to go ahead and fix the z-index issue we are having with MSIE... r54654.

And yes, I think if we are keeping this, it could use some UI love to become a little more inviting. I am thinking a background image of a Firefox logo, for example.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

The button is centered using Opera, but not in IE 7; weird.

Comment 20

[Fred Wenzel [:wenzel]]

Yea, IE7 has trouble centering divs. Do we feel strongly about it? I guess that depends on if there's going to be a different layout of the overlay or not?

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry to play whack-a-mole, Wenzel, but attached is what it looks like in Opera 10 -- can you fix?

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of Opera 10

Comment 23

[Fred Wenzel [:wenzel]]

Sigh, I have no idea how to fix this, but I'll take a look. Thanks for the persistence, Stephen :)

Comment 24

[Ryan Doherty (:rdoherty)]

(In reply to comment #23)
> Sigh, I have no idea how to fix this, but I'll take a look. Thanks for the
> persistence, Stephen :)

This may be a ridiculous solution, but I've heard of many JS frameworks adding an empty iframe behind their content to prevent bleed-through of random elements (flash, form elements).

Your other option is to simply hide all form elements when popping up the modal dialog.

Comment 25

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Thanks, excellent suggestion, Ryan. I went with hiding all visible form elements (visibility:hidden so the page doesn't jump) and I was able to test it successfully in Opera also.

Comment 26

[Ryan Doherty (:rdoherty)]

Comment on attachment 409880 [details] [diff] [review]
Patch, rev. 2

b-e-a-utiful

Comment 27

[Fred Wenzel [:wenzel]]

Yay. r54968.

Comment 28

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; much better indeed!  Thanks, Fred.

Comment 29

[Intermittent Failures Robot]

1 failures in 2708 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* linux64-jsdcov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=494195&startday=2018-10-01&endday=2018-10-07&tree=all