Closed Bug 494449 Opened 16 years ago Closed 16 years ago

RTL support for the featured add-ons box in the new AMO theme

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aaronmt, Assigned: ehsan.akhgari)

References

()

Details

(Keywords: rtl)

Attachments

(3 files)

When viewing a summary of addons in an RTL language, icons of the associated addon are overlayed ontop of text. As a result, text is hidden from reading. In the URL screenshot above one can see this.
OS: Mac OS X → All
Hardware: x86 → All
You would be looking at FoxyTune, Fire.FM in the screenshot. In the case of the middle addon, AllMusic - the title text is truncated.
Second example - have a look at the top right (firebug icon underneath robcee, dolske) https://preview.addons.mozilla.org/he/firefox/addon/1843
Assignee: nobody → ehsan.akhgari
I'm morphing this bug to cover the whole featured add-ons box. This box does not have any RTL support right now; the patch that I'll be attaching in a moment implements full RTL support for it.
Keywords: rtl
Summary: Summary images on top of summary text of addons when viewed in RTL language → RTL support for the featured add-ons box in the new AMO theme
Attached patch Patch Splinter Review
Attachment #379340 - Attachment is patch: true
Attachment #379340 - Attachment mime type: application/octet-stream → text/plain
Attachment #379340 - Flags: review?(stephen.donner)
Attached image Image used in the patch
This image should probably be edited for the correct direction of the texts, I simply mirrored it in Gimp because I don't have the source graphic files used to create it.
Attachment #379341 - Flags: review?(stephen.donner)
Status: NEW → ASSIGNED
Depends on: amo2009-rtl
Blocks: amo2009-rtl
No longer depends on: amo2009-rtl
Attachment #379340 - Flags: review?(stephen.donner) → review?(clouserw)
Attachment #379341 - Flags: review?(stephen.donner) → review?(clouserw)
Attachment #379340 - Flags: review?(clouserw) → review+
Comment on attachment 379341 [details] Image used in the patch It looks like there is a watermark on this image... I wonder where it came from.
Attachment #379341 - Flags: review?(clouserw) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: